Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register storage_account as second name for storage metricset #28447

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Register storage_account as second name for storage metricset #28447

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebed413
add storage
narph Oct 14, 2021
b46904c
Merge branch 'master' into azure-storage-name
narph Oct 14, 2021
67ca81e
Merge branch 'master' into azure-storage-name
narph Oct 14, 2021
938024e
changelog
narph Oct 15, 2021
87ec850
add fields
narph Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,7 @@ for a few releases. Please use other tools provided by Elastic to fetch data fro
- Move openmetrics module to oss. {pull}26561[26561]
- Add `gke` metricset collection to `gcp` module {pull}26824[26824]
- Added a new beta `enterprisesearch` module for Elastic Enterprise Search {pull}27549[27549]
- Register additional name for `storage` metricset in the azure module. {pull}28447[28447]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to document this or show some deprecation warning in the old name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no deprecation, I don't plan to change the name, just want to remove the pipeline in the future

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are both metricsets going to stay forever in beats?


*Packetbeat*

Expand Down
1 change: 1 addition & 0 deletions x-pack/metricbeat/module/azure/storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ var (
// MetricSet has been created then Fetch will begin to be called periodically.
func init() {
mb.Registry.MustAddMetricSet("azure", "storage", New)
mb.Registry.MustAddMetricSet("azure", "storage_account", New)
jsoriano marked this conversation as resolved.
Show resolved Hide resolved
}

// MetricSet holds any configuration or state information. It must implement
Expand Down