[filebeat] Add base64Decode template functions to httpjson #28385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-gr
added
enhancement
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
marc-gr
force-pushed
the
add-decode-funcs
branch
from
09a0e7d to
38557b8
Compare
efd6
reviewed
Oct 13, 2021
|
|
||
| func base64DecodeNoPad(enc string) string { | ||
| dec, _ := base64.RawStdEncoding.DecodeString(enc) | ||
| return string(dec) |
There was a problem hiding this comment.
Maybe emit and obviously incorrect string if err != nil? (also above)
There was a problem hiding this comment.
Not sure here, what would you suggest? maybe a no-op is better in this case (and document accordingly)?
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
P1llus
approved these changes
Oct 14, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
(cherry picked from commit 6ad8689)
marc-gr
added a commit
that referenced
this pull request
Oct 14, 2021
(cherry picked from commit 6ad8689) Co-authored-by: Marc Guasch <[email protected]>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds template functions to decode base64 strings.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.