Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] gcp.gke: uniform metric's fields #28368

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

endorama
Copy link
Member

@endorama endorama commented Oct 12, 2021

What does this PR do?

Uniform gcp.gke fields.yml file: flatten and sort fields, add TestFetch integration test and fix resulting missing fields.

Why is it important?

As part of #27974 this PR uniform gcp.gke metricset fields.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Run tests TEST_TAGS=gcp MODULE=gcp mage goIntegTest
  • updated fields.go before merging

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@endorama endorama added Team:Integrations Label for the Integrations team backport-v7.16.0 Automated backport with mergify labels Oct 12, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 12, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-13T15:06:29.996+0000

  • Duration: 112 min 35 sec

  • Commit: 534efb4

Test stats 🧪

Test Results
Failed 0
Passed 9538
Skipped 2537
Total 12075

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@endorama endorama changed the title [Metricbeat] gcp.billing: uniform metric's fields [Metricbeat] gcp.gke: uniform metric's fields Oct 12, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp/uniform-fields-gke upstream/gcp/uniform-fields-gke
git merge upstream/master
git push upstream gcp/uniform-fields-gke

@endorama endorama force-pushed the gcp/uniform-fields-gke branch from b1400bb to 534efb4 Compare October 13, 2021 15:06
@endorama endorama merged commit 568fd05 into elastic:master Oct 14, 2021
@endorama endorama deleted the gcp/uniform-fields-gke branch October 14, 2021 10:27
endorama added a commit that referenced this pull request Oct 14, 2021
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants