-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] gcp.compute: uniform metricset's fields #28367
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This pull request is now in conflicts. Could you fix it? 🙏
|
3201853
to
baaa19c
Compare
* gcp.compute: flatten fields * gcp.compute: fix firewall docs * gcp.compute: sort fields * gcp.compute: add TestFetch * gcp.compute: fix undocumented field * gcp: update fields * metricbeat: mage update (cherry picked from commit 3db67f6) # Conflicts: # metricbeat/docs/fields.asciidoc # x-pack/metricbeat/module/gcp/fields.go
* gcp.compute: flatten fields * gcp.compute: fix firewall docs * gcp.compute: sort fields * gcp.compute: add TestFetch * gcp.compute: fix undocumented field * gcp: update fields * metricbeat: mage update (cherry picked from commit 3db67f6)
* gcp.compute: flatten fields * gcp.compute: fix firewall docs * gcp.compute: sort fields * gcp.compute: add TestFetch * gcp.compute: fix undocumented field * gcp: update fields * metricbeat: mage update (cherry picked from commit 3db67f6) Co-authored-by: endorama <[email protected]>
* gcp.compute: flatten fields * gcp.compute: fix firewall docs * gcp.compute: sort fields * gcp.compute: add TestFetch * gcp.compute: fix undocumented field * gcp: update fields * metricbeat: mage update
What does this PR do?
Uniform
gcp.compute
fields.yml
file: flatten and sort fields, addTestFetch
integration test and fix resulting missing fields.Why is it important?
As part of #27974 this PR uniform
gcp.compute
metricset fields.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
TEST_TAGS=gcp MODULE=gcp mage goIntegTest
fields.go
before mergingHow to test this PR locally
Related issues
Use cases
Screenshots
Logs