Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] gcp.compute: uniform metricset's fields #28367

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

endorama
Copy link
Member

@endorama endorama commented Oct 12, 2021

What does this PR do?

Uniform gcp.compute fields.yml file: flatten and sort fields, add TestFetch integration test and fix resulting missing fields.

Why is it important?

As part of #27974 this PR uniform gcp.compute metricset fields.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Run tests TEST_TAGS=gcp MODULE=gcp mage goIntegTest
  • updated fields.go before merging

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@endorama endorama added Team:Integrations Label for the Integrations team backport-v7.16.0 Automated backport with mergify labels Oct 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 12, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T15:46:41.419+0000

  • Duration: 100 min 15 sec

  • Commit: baaa19c

Test stats 🧪

Test Results
Failed 0
Passed 9538
Skipped 2537
Total 12075

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@endorama endorama changed the title gcp.compute: flatten fields [Metricbeat] gcp.compute: uniform metricset's fields Oct 12, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp/uniform-fields-compute upstream/gcp/uniform-fields-compute
git merge upstream/master
git push upstream gcp/uniform-fields-compute

@endorama endorama force-pushed the gcp/uniform-fields-compute branch from 3201853 to baaa19c Compare October 14, 2021 15:46
@endorama endorama merged commit 3db67f6 into elastic:master Oct 14, 2021
@endorama endorama deleted the gcp/uniform-fields-compute branch October 14, 2021 17:44
mergify bot pushed a commit that referenced this pull request Oct 14, 2021
* gcp.compute: flatten fields

* gcp.compute: fix firewall docs

* gcp.compute: sort fields

* gcp.compute: add TestFetch

* gcp.compute: fix undocumented field

* gcp: update fields

* metricbeat: mage update

(cherry picked from commit 3db67f6)

# Conflicts:
#	metricbeat/docs/fields.asciidoc
#	x-pack/metricbeat/module/gcp/fields.go
endorama added a commit that referenced this pull request Oct 15, 2021
* gcp.compute: flatten fields

* gcp.compute: fix firewall docs

* gcp.compute: sort fields

* gcp.compute: add TestFetch

* gcp.compute: fix undocumented field

* gcp: update fields

* metricbeat: mage update

(cherry picked from commit 3db67f6)
endorama added a commit that referenced this pull request Oct 15, 2021
* gcp.compute: flatten fields

* gcp.compute: fix firewall docs

* gcp.compute: sort fields

* gcp.compute: add TestFetch

* gcp.compute: fix undocumented field

* gcp: update fields

* metricbeat: mage update

(cherry picked from commit 3db67f6)

Co-authored-by: endorama <[email protected]>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
* gcp.compute: flatten fields

* gcp.compute: fix firewall docs

* gcp.compute: sort fields

* gcp.compute: add TestFetch

* gcp.compute: fix undocumented field

* gcp: update fields

* metricbeat: mage update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants