Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] gcp.billing: uniform metricset's fields #28366

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

endorama
Copy link
Member

@endorama endorama commented Oct 12, 2021

What does this PR do?

Uniform gcp.billing fields.yml file.

Why is it important?

As part of #27974 this PR uniform gcp.billing metricset fields.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Run tests TEST_TAGS=gcp MODULE=gcp mage goIntegTest cc @kaiyan-sheng
  • updated fields.go before merging

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@endorama endorama added Team:Integrations Label for the Integrations team backport-v7.16.0 Automated backport with mergify labels Oct 12, 2021
@endorama endorama requested a review from kaiyan-sheng October 12, 2021 14:26
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 12, 2021
@endorama endorama changed the title [Metricbeat] gcp.billing: uniform metric's fields [Metricbeat] gcp.billing: uniform metricset's fields Oct 12, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-12T14:48:24.877+0000

  • Duration: 67 min 15 sec

  • Commit: c06998f

Test stats 🧪

Test Results
Failed 0
Passed 2696
Skipped 248
Total 2944

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@endorama endorama merged commit 75e17fb into elastic:master Oct 13, 2021
@endorama endorama deleted the gcp/uniform-fields-billing branch October 13, 2021 07:56
mergify bot pushed a commit that referenced this pull request Oct 13, 2021
endorama added a commit that referenced this pull request Oct 13, 2021
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants