Add '_monitoring' suffix to monitoring process names #27852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add '_monitoring' suffix to monitoring process names so that they can be distinguised from other processes. This is relevent for the status command where the beat instances appear the same in output. Changed the output format of the human readable option to better align text with the longer names.
michel-laterman
added
bug
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ruflin
approved these changes
Sep 10, 2021
| } | ||
|
|
||
| if p.ServicePort() == 0 { | ||
| // Applications without service ports defined are ran as through the process application type. | ||
| a, err = process.NewApplication( | ||
| o.bgContext, | ||
| p.ID(), | ||
| p.BinaryName(), | ||
| appName, |
There was a problem hiding this comment.
I wonder if this has any effect in other places except the status output? Hopefully a positive impact but we should double check in case we do any comparison on appName.
There was a problem hiding this comment.
From what I can see it should be safe to change it like this, the Application that is returned exposes it for use by other processes with the Name function
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
* Add '_monitoring' suffix to monitoring process names Add '_monitoring' suffix to monitoring process names so that they can be distinguished from other processes. This is relevant for the status command where the beat instances appear the same in output. Changed the output format of the human readable option to better align text with the longer names. (cherry picked from commit eb0a886)
michel-laterman
added a commit
that referenced
this pull request
Sep 11, 2021
* Add '_monitoring' suffix to monitoring process names Add '_monitoring' suffix to monitoring process names so that they can be distinguished from other processes. This is relevant for the status command where the beat instances appear the same in output. Changed the output format of the human readable option to better align text with the longer names. (cherry picked from commit eb0a886) Co-authored-by: Michel Laterman <[email protected]>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
* Add '_monitoring' suffix to monitoring process names Add '_monitoring' suffix to monitoring process names so that they can be distinguished from other processes. This is relevant for the status command where the beat instances appear the same in output. Changed the output format of the human readable option to better align text with the longer names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add '_monitoring' suffix to monitoring process names so that they can be
distinguished from other processes. This is relevant for the status
command where the beat instances appear the same in output. Changed the
output format of the human readable option to better align text with the
longer names.
Why is it important?
Allows users to determine if the monitoring instances, or "regular" beats instances are healthy.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
run
elastic-agent statusRelated issues
Logs
Example of the new output: