Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][httpjson] Fix incorrect key for template data #26848

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 12, 2021

What does this PR do?

Fixes the key used for the url parameters in the transform context from params to url.params which was documented in https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#input-state

Why is it important?

Users wanting to access using url.params will not be able to do it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr added bug Team:Security-External Integrations backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Jul 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 12, 2021
@marc-gr marc-gr force-pushed the fix-httpjson-key branch from 5b638bb to edde482 Compare July 12, 2021 16:23
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-13T07:13:22.582+0000

  • Duration: 93 min 14 sec

  • Commit: a6447fd

Test stats 🧪

Test Results
Failed 0
Passed 7818
Skipped 1201
Total 9019

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7818
Skipped 1201
Total 9019

@marc-gr marc-gr force-pushed the fix-httpjson-key branch from edde482 to 02bf173 Compare July 13, 2021 07:10
@marc-gr marc-gr force-pushed the fix-httpjson-key branch from 02bf173 to a6447fd Compare July 13, 2021 07:13
@marc-gr marc-gr merged commit eb758b9 into elastic:master Jul 13, 2021
@marc-gr marc-gr deleted the fix-httpjson-key branch July 13, 2021 08:47
mergify bot pushed a commit that referenced this pull request Jul 13, 2021
* [httpjson] Fix incorrect key for template data

* Add test

(cherry picked from commit eb758b9)
mergify bot pushed a commit that referenced this pull request Jul 13, 2021
* [httpjson] Fix incorrect key for template data

* Add test

(cherry picked from commit eb758b9)
marc-gr added a commit that referenced this pull request Jul 13, 2021
* [httpjson] Fix incorrect key for template data

* Add test

(cherry picked from commit eb758b9)

Co-authored-by: Marc Guasch <[email protected]>
marc-gr added a commit that referenced this pull request Jul 13, 2021
* [httpjson] Fix incorrect key for template data

* Add test

(cherry picked from commit eb758b9)

Co-authored-by: Marc Guasch <[email protected]>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jul 19, 2021
* master: (61 commits)
  Add disk queue unit tests based on the queuetest package
  [Heartbeat] redact authorization headers from logger (elastic#26892)
  Expose custom process metrics  (elastic#26912)
  [gcp/billing] always quote table name identifier (elastic#26870)
  Add Beats central management removal to BCs (elastic#26400)
  Add custom suffix to identifiers in filestream input when needed (elastic#26669)
  Update asa-ftd-pipeline.yml (elastic#26265)
  Use common host parser in vsphere module (elastic#26904)
  [automation] Update go release version 1.16.6 (elastic#26860)
  Skip flaky test: filestream and harvester group (elastic#26728)
  [Filebeat] Remove alias fields from Suricata and Traefik module mappings (elastic#26627)
  docs: apm-server.auth (elastic#26831)
  [Automation] Update elastic stack version to 8.0.0-2f008f4a for testing (elastic#26881)
  Clarify the scope of start/end multiline example (elastic#26786)
  [Heartbeat]: update Node.js version for synthetics (elastic#26867)
  [fix][httpjson] Fix incorrect key for template data (elastic#26848)
  [httpjson] Add value_type parameter to httpjson transforms (elastic#26847)
  [Heartbeat]: capture error from journey/end events (elastic#26781)
  [Winlogbeat] Fixes for wineventlog experimental api (elastic#26826)
  Set agent.id to Fleet Agent ID for each metric/log monitoring input (elastic#26776)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants