Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Remove symlink.prev from previously failed upgrade #26785

Merged
merged 8 commits into from
Jul 9, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jul 8, 2021

What does this PR do?

This PR removes symlink prev before starting upgrade procedure

Why is it important?

In case .prev is left there because of failure in previous upgrades it will fail to upgrade on cannot create symlink, file already exists error

Fixes: #26513

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Jul 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 8, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-08T07:42:02.240+0000

  • Duration: 70 min 15 sec

  • Commit: 7d6f513

Test stats 🧪

Test Results
Failed 0
Passed 6972
Skipped 16
Total 6988

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6972
Skipped 16
Total 6988

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michalpristas michalpristas merged commit d421582 into elastic:master Jul 9, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Jul 9, 2021
…lastic#26785)

[Elastic Agent] Remove symlink.prev from previously failed upgrade (elastic#26785)
michalpristas added a commit to michalpristas/beats that referenced this pull request Jul 9, 2021
…lastic#26785)

[Elastic Agent] Remove symlink.prev from previously failed upgrade (elastic#26785)
michalpristas added a commit that referenced this pull request Jul 9, 2021
…26785) (#26806)

[Elastic Agent] Remove symlink.prev from previously failed upgrade (#26785)
michalpristas added a commit that referenced this pull request Jul 9, 2021
…26785) (#26807)

[Elastic Agent] Remove symlink.prev from previously failed upgrade (#26785)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent Label for the Agent team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: when upgrading an agent, it fails because of existing simlink elastic-agent.exe.prev
3 participants