-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Remove symlink.prev from previously failed upgrade #26785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bug/symlink.prev
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 8, 2021
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Jul 9, 2021
…lastic#26785) [Elastic Agent] Remove symlink.prev from previously failed upgrade (elastic#26785)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Jul 9, 2021
…lastic#26785) [Elastic Agent] Remove symlink.prev from previously failed upgrade (elastic#26785)
This was referenced Jul 9, 2021
michalpristas
added a commit
that referenced
this pull request
Jul 9, 2021
michalpristas
added a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes symlink prev before starting upgrade procedure
Why is it important?
In case .prev is left there because of failure in previous upgrades it will fail to upgrade on
cannot create symlink, file already exists
errorFixes: #26513
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.