-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][metricbeat] Change default value for server_status_path in nginx module #26642
Conversation
a2bece8
to
045e8b4
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Is this a breaking change for users that were relying on the default? Or would no one be using the default? |
From my understanding, this change was intended to happen here #14730, but was missing the bits in this PR. I'd like @kaiyan-sheng to confirm both my assumption and if it is a breaking change, and in that case how we should proceed. |
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
045e8b4
to
37a22d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
(cherry picked from commit 1af44b0)
(cherry picked from commit 1af44b0)
…27193) (cherry picked from commit 1af44b0) Co-authored-by: Marc Guasch <[email protected]>
…27194) (cherry picked from commit 1af44b0) Co-authored-by: Marc Guasch <[email protected]>
What does this PR do?
Fixes the default path for the nginx module from
server-status
tonginx_status
Why is it important?
If set by default the endpoint will return a 404
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.