Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][metricbeat] Change default value for server_status_path in nginx module #26642

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 1, 2021

What does this PR do?

Fixes the default path for the nginx module from server-status to nginx_status

Why is it important?

If set by default the endpoint will return a 404

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr added bug Metricbeat Metricbeat backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Jul 1, 2021
@marc-gr marc-gr requested a review from kaiyan-sheng July 1, 2021 09:59
@marc-gr marc-gr force-pushed the fix-nginx-status-path branch from a2bece8 to 045e8b4 Compare July 1, 2021 10:02
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-02T10:00:57.912+0000

  • Duration: 78 min 54 sec

  • Commit: 37a22d0

Test stats 🧪

Test Results
Failed 0
Passed 9038
Skipped 2410
Total 11448

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9038
Skipped 2410
Total 11448

@andrewkroh
Copy link
Member

andrewkroh commented Jul 8, 2021

Is this a breaking change for users that were relying on the default? Or would no one be using the default?

@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 8, 2021

Is this a breaking change for users that were relying on the default? Or would no one be using the default?

From my understanding, this change was intended to happen here #14730, but was missing the bits in this PR. I'd like @kaiyan-sheng to confirm both my assumption and if it is a breaking change, and in that case how we should proceed.

@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-nginx-status-path upstream/fix-nginx-status-path
git merge upstream/master
git push upstream fix-nginx-status-path

@kaiyan-sheng
Copy link
Contributor

@marc-gr Sorry maybe the original PR from the community shouldn't be merged. Seems like this is not simply a documentation change but since the existing default path causes a 404 error, I would consider it as a bug fix instead of breaking change.

@marc-gr marc-gr added Team:Security-External Integrations and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr force-pushed the fix-nginx-status-path branch from 045e8b4 to 37a22d0 Compare August 2, 2021 10:00
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@marc-gr marc-gr merged commit 1af44b0 into elastic:master Aug 2, 2021
@marc-gr marc-gr deleted the fix-nginx-status-path branch August 2, 2021 14:04
mergify bot pushed a commit that referenced this pull request Aug 2, 2021
mergify bot pushed a commit that referenced this pull request Aug 2, 2021
marc-gr added a commit that referenced this pull request Aug 3, 2021
marc-gr added a commit that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify bug Metricbeat Metricbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants