Fix master's linting issue #26517
Merged
Fix master's linting issue #26517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
mtojek
approved these changes
Jun 28, 2021
| "github.com/google/go-cmp/cmp" | ||
|
|
||
| "github.com/elastic/beats/v7/libbeat/logp" | ||
|
|
There was a problem hiding this comment.
nit: should there be an empty line?
There was a problem hiding this comment.
This is what mage ftm gave, but yes removing is ok. Thanks!
| "github.com/google/go-cmp/cmp" | ||
| "github.com/kolide/osquery-go/plugin/logger" | ||
|
|
||
| "github.com/elastic/beats/v7/libbeat/logp" | ||
|
|
Signed-off-by: chrismark <[email protected]>
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Log outputExpand to view the last 100 lines of log output
|
jsoriano
approved these changes
Jun 28, 2021
|
@jsoriano I also saw that these tricky lines are there for some time now. I just checkout latest master and run |
kaiyan-sheng
approved these changes
Jun 28, 2021
|
I will move on and merge this since there is an known issue with the windows-8 workers. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Fix master's linting issue Signed-off-by: chrismark <[email protected]> * Remove empty lines Signed-off-by: chrismark <[email protected]> (cherry picked from commit 48935ee)
ChrsMark
added a commit
that referenced
this pull request
Jun 29, 2021
* Fix master's linting issue Signed-off-by: chrismark <[email protected]> * Remove empty lines Signed-off-by: chrismark <[email protected]> (cherry picked from commit 48935ee) Co-authored-by: Chris Mark <[email protected]>
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jun 29, 2021
* master: Osquerybeat: set the raw index name to supress the timestamp suffix (elastic#26545) [Heartbeat] add screenshots config to synthetics (elastic#26455) [Elastic Agent] Use http2 to connect to Fleet Server. (elastic#26474) Remove all docs about Beats central management (elastic#26399) update data.json for gcp billing (elastic#26506) Skip x-pack metricbeat tests (elastic#26537) [Elastic Agent] Fix issue with FLEET_CA not being used with Fleet Server in container (elastic#26529) Add changelog entry for elastic#26224 (elastic#26531) Add inttests for the x-pack/metricbeat on a PR/branches basis (elastic#26526) Suppress too many errors (elastic#26224) Fix master's linting issue (elastic#26517) [libbeat] Fix encoding and file offset issues in the disk queue (elastic#26484) Add log_group_name_prefix config option for aws-cloudwatch input (elastic#26187) Update shared-deduplication.asciidoc (elastic#26492) Add Recorded Future support to threatintel module (elastic#26481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes lint issues in current master. Failures spotted at #26438.