[Docs] Fixed metricbeat redis exported field CPU descriptions #25846
Conversation
These were mixed up.
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
Hi! We're labeling this issue as |
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
needs_team
|
/test |
|
Hey @joostdecock, This change should be applied in master first, could you please rebase the PR? Also, the file you changed is autogenerated, these changes should be done in the fields definition in the redis module, here. Thanks! |
|
Can't really remember how I ended up selecting a branch 🤔 As for updating an auto-generated file: I clicked that Edit this file on github link in the docs. At work now, will let this sit in my inbox for later. |
Oops, sorry, yes, I think this button should be improved 😬 @dedemorton do you know if there is something we can do to make this link point to the correct file in the master branch? |
|
@joostdecock We definitely don't want the documentation to lie, so thank you for submitting this request! @jsoriano There used to be a way to override edit links, but I think that went away with some "improvements" we made to the doc build. It might still be possible, but I don't think it's a good idea because in many cases you need to run So...whenever a PR comes in from the community through the Edit link, I'm happy to make the changes needed to get the doc build running, then I'll backport and/or forwardport the commit. I don't want folks to feel discouraged about contributing to the docs, or feel like they need to get up to speed on our build environment just to make a few simple edits. Feel free to assign PRs like this to me in the future, and I'll take care of them. |
|
The commit I pushed should fix the build problem. I'll take care of merging and backporting. Thanks! |
|
jenkins run the tests please |
…c#25846) * Fixed redis CPU descriptions These were mixed up. * Make changes to fields.yml in meta dir Co-authored-by: dedemorton <[email protected]>
…c#25846) * Fixed redis CPU descriptions These were mixed up. * Make changes to fields.yml in meta dir Co-authored-by: dedemorton <[email protected]>
…c#25846) * Fixed redis CPU descriptions These were mixed up. * Make changes to fields.yml in meta dir Co-authored-by: dedemorton <[email protected]>
|
Thanks @dedemorton! |
#26494) * Fixed redis CPU descriptions These were mixed up. * Make changes to fields.yml in meta dir Co-authored-by: dedemorton <[email protected]> Co-authored-by: Joost De Cock <[email protected]>
#26495) * Fixed redis CPU descriptions These were mixed up. * Make changes to fields.yml in meta dir Co-authored-by: dedemorton <[email protected]> Co-authored-by: Joost De Cock <[email protected]>
#26496) * Fixed redis CPU descriptions These were mixed up. * Make changes to fields.yml in meta dir Co-authored-by: dedemorton <[email protected]> Co-authored-by: Joost De Cock <[email protected]>
* master: (25 commits) fix: Force PLATFORMS environment variable when we build Elastic Agent dependencies on arm64 (elastic#26415) macos for metricbeat to run in the extended meta-stage (elastic#26573) Packaging: add arm7 platform in the main pipeline (elastic#26575) [Heartbeat] Skip flakey timer queue test (elastic#26592) Update to "read_pipeline" permission (elastic#26465) (elastic#26580) API keys do not reflect the need for read_pipeline (elastic#26466) (elastic#26582) Add Fleet agent.id to Agent monitoring data (elastic#26548) Add kinesis metricset (elastic#25989) Refactor of system/memory metricset (elastic#26334) Introduce httpcommon package in libbeat (add support for Proxy) (elastic#25219) [Filebeat] change multiline configuration in awss3 input to parsers (elastic#25873) docs: Hint for the error "Error extracting container id" (elastic#25824) [Docs] Fixed metricbeat redis exported field CPU descriptions (elastic#25846) (elastic#26496) Update urllib to 1.26.5. (elastic#26380) Update golang.org/x/crypto (elastic#26448) [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816) Move parsers outside of filestream input so others can use them as well (elastic#26541) [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508) [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620) Logging code cleanup related to Nomad auto-discovery (elastic#26498) ...
…c#25846) * Fixed redis CPU descriptions These were mixed up. * Make changes to fields.yml in meta dir Co-authored-by: dedemorton <[email protected]>
What does this PR do?
Fixed descriptions that were mixed up.
Why is it important?
The name is pretty self-explanatory, but still. Documentation shouldn't lie.
Author's Checklist
How to test this PR locally
Docs changes only
Use cases
People looking up the definition of the exported fields should get correct results.