[Elastic Agent] Handle case where policy doesn't contain Fleet connection information #25707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
Agent
backport-v7.13.0
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ph
approved these changes
May 13, 2021
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
blakerouse
added a commit
that referenced
this pull request
May 14, 2021
…tion information (#25707) (#25713) * Handle case where policy doesn't contain Fleet connection information. * Add changelog entry. (cherry picked from commit e86109e) Co-authored-by: Blake Rouse <[email protected]>
blakerouse
added a commit
that referenced
this pull request
May 14, 2021
…tion information (#25707) (#25714) * Handle case where policy doesn't contain Fleet connection information. * Add changelog entry. (cherry picked from commit e86109e) Co-authored-by: Blake Rouse <[email protected]>
ruflin
reviewed
May 17, 2021
| return errors.New(err, "could not convert the configuration from the policy", errors.TypeConfig) | ||
| } | ||
| if _, ok := data["fleet"]; !ok { | ||
| // no fleet information in the configuration (skip checking client) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that the client connection to Fleet Server is only updated if the policy has
fleet.*.Why is it important?
Fixes #25586 because of kibana issue elastic/kibana#100050
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues