Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go version to 1.16.4 #25671

Merged
merged 15 commits into from
May 28, 2021
Merged

Update Go version to 1.16.4 #25671

merged 15 commits into from
May 28, 2021

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented May 11, 2021 •
edited
Loading

What does this PR do?

Update the version of Go being used to 1.16.4

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@michel-laterman michel-laterman added enhancement review Team:Elastic-Agent Label for the Agent team 7.14 Candidate backport-v7.14.0 Automated backport with mergify labels May 11, 2021
@michel-laterman michel-laterman requested a review from kvch May 11, 2021 18:44
@michel-laterman michel-laterman requested a review from a team as a code owner May 11, 2021 18:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 11, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 11, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: michel-laterman commented: /test

  • Start Time: 2021-05-28T00:10:09.389+0000

  • Duration: 97 min 16 sec

  • Commit: 1e7007c

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@michel-laterman
Copy link
Contributor Author

jenkins run tests

@mergify
Copy link
Contributor

mergify bot commented May 13, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b go-1.16.3 upstream/go-1.16.3
git merge upstream/master
git push upstream go-1.16.3

@kvch
Copy link
Contributor

kvch commented May 20, 2021

The PR LGTM. Could you please open two issues for the two flaky tests and disable them?

@urso
Copy link

urso commented May 20, 2021

LGTM. It's just one flaky test. The second is the 'parent' test that is automatically marked as failed.

@urso
Copy link

urso commented May 20, 2021

Please add an entry to the breaking changes section in Changelog.next.asciidoc about requiring OS X 10.14 minimum.

@michel-laterman
Copy link
Contributor Author

jenkins run tests

kvch
kvch reviewed May 25, 2021
View reviewed changes
CHANGELOG-developer.next.asciidoc Outdated
@@ -113,4 +114,5 @@ The list below covers the major changes between 7.0.0-rc2 and master only.
- Update Go version to 1.15.9. {pull}24442[24442]
- Update Go version to 1.15.10. {pull}24606[24606]
- Update Go version to 1.15.12. {pull}25629[25629]
- Update Go version to 1.16.4. {issue}25346[25346]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a reference to the PR.

@michel-laterman
Copy link
Contributor Author

/test

@michel-laterman
Copy link
Contributor Author

/test

@michel-laterman
Copy link
Contributor Author

/test

@kvch
Copy link
Contributor

kvch commented May 27, 2021

/packaging

@michel-laterman
Copy link
Contributor Author

/test

@michel-laterman
Copy link
Contributor Author

/packaging

@michel-laterman
Copy link
Contributor Author

/test

@michel-laterman
Copy link
Contributor Author

/test

1 similar comment
@michel-laterman
Copy link
Contributor Author

/test

@kvch
Copy link
Contributor

kvch commented May 28, 2021

Failing tests are unrelated.

@urso
Copy link

urso commented May 28, 2021

Looks good. We can merge the PR as is.

@michel-laterman michel-laterman merged commit 4dc5285 into elastic:master May 28, 2021
@michel-laterman michel-laterman deleted the go-1.16.3 branch May 28, 2021 16:01
mergify bot pushed a commit that referenced this pull request May 28, 2021
@michel-laterman
Update Go version to 1.16.4 (#25671)
2ccc5be 
Update to go v1.16.4. Change MacOS cross compile to use
debian 10 image and 10.14 of the SDK. Fix arm7 packaging.

(cherry picked from commit 4dc5285)

# Conflicts:
#	libbeat/docs/version.asciidoc
@mergify mergify bot mentioned this pull request May 28, 2021
Merged
michel-laterman added a commit that referenced this pull request May 31, 2021
@mergify @michel-laterman
[7.x](backport #25671) Update Go version to 1.16.4 (#25994)
7cc2b30 
* Update Go version to 1.16.4 (#25671)

Update to go v1.16.4. Change MacOS cross compile to use
debian 10 image and 10.14 of the SDK. Fix arm7 packaging.

(cherry picked from commit 4dc5285)

# Conflicts:
#	libbeat/docs/version.asciidoc

* update version.asciidoc

Co-authored-by: Michel Laterman <[email protected]>
@v1v v1v mentioned this pull request Jun 29, 2021
Closed
3 tasks
@v1v v1v mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

@urso urso urso approved these changes

Assignees
No one assigned
Labels
7.14 Candidate backport-v7.14.0 Automated backport with mergify enhancement review Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michel-laterman @elasticmachine @kvch @urso