[Elastic Agent] Retry deamon reload during enroll #25590
Conversation
michalpristas
added
bug
needs_backport
botelastic
bot
added
needs_team
|
/package |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
/package |
|
Pinging @elastic/agent (Team:Agent) |
|
@blakerouse Can you review this, @michalpristas I've moved to the right board :) |
|
|
||
| for i := 5; i >= 0; i-- { | ||
| retry := false | ||
| if errors.Is(err, fleetapi.ErrTooManyRequests) { |
There was a problem hiding this comment.
These errors don't seem to apply to daemon reloading.
| func (c *enrollCmd) daemonReloadWithBackoff(ctx context.Context) error { | ||
| err := c.daemonReload(ctx) | ||
| signal := make(chan struct{}) | ||
| backExp := backoff.NewExpBackoff(signal, 60*time.Second, 10*time.Minute) |
There was a problem hiding this comment.
Can we start with lower amounts? This seems rather large initial wait. Maybe lets do like 10 seconds to maximum of 1 minute?
This is a local daemon it should be quick to connect and communicate.
| @@ -323,6 +323,24 @@ func (c *enrollCmd) prepareFleetTLS() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *enrollCmd) daemonReloadWithBackoff(ctx context.Context) error { | |||
| err := c.daemonReload(ctx) | |||
There was a problem hiding this comment.
If no error here then no reason to continue. Just return as it has been reloaded.
[Elastic Agent] Retry deamon reload during enroll (elastic#25590)
[Elastic Agent] Retry deamon reload during enroll (elastic#25590)
What does this PR do?
Adds retry for daemon reload
Why is it important?
elastic/fleet-server#297
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.