[Elastic Agent] Fixed status reporting #25584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kvch
approved these changes
May 6, 2021
|
Also, test failure is going to be fixed by: #25587 |
|
Tested, works well. |
blakerouse
reviewed
May 6, 2021
| switch e := err.(type) { | ||
| case apiError: | ||
| w.WriteHeader(e.Status()) | ||
| default: | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
|
|
||
| } | ||
|
|
||
| writeResponse(w, unexpectedErrorWithReason(err.Error())) |
There was a problem hiding this comment.
Possible to add a unit test for this code path? Having a unit test would have been an easy way to catch this.
michalpristas
added
the
needs_backport
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 12, 2021
[Elastic Agent] Fixed status reporting (elastic#25584)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 12, 2021
[Elastic Agent] Fixed status reporting (elastic#25584)
This was referenced May 12, 2021
michalpristas
added a commit
that referenced
this pull request
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed some issues discovered on testing.
First one is not to use overwrites when in standalone mode second one is that status code was always 200. (written after body)
Why is it important?
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.