Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "[CI] googleStorageUploadExt step (#24048)"" #25517

Merged
merged 1 commit into from
May 4, 2021
Merged

Revert "Revert "[CI] googleStorageUploadExt step (#24048)"" #25517

merged 1 commit into from
May 4, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented May 4, 2021 •
edited
Loading

Reverts #25454

Rationale

We hit jenkinsci/google-storage-plugin#61 therefore the only way for the time being to bypass that particular issue is to use the adhoc approach we built.

The latest version of the google storage plugin had a fix for this issue, but unfortunately it did not solve the underlying issue.

If we don't use this fix then there will be stalled builds which will never finish and consume the CI capacity.

image

@v1v v1v requested a review from a team as a code owner May 4, 2021 09:27
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 4, 2021
@v1v v1v added backport-v7.14.0 Automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label labels May 4, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2021
@botelastic
Copy link

botelastic bot commented May 4, 2021

This pull request doesn't have a Team:<team> label.

@v1v v1v added the backport-v7.13.0 Automated backport with mergify label May 4, 2021
@v1v v1v self-assigned this May 4, 2021
cachedout
cachedout approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but it would be good if the PR had a better description of why this is needed, or linked to an issue so we can track what happened in the future. :)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25517 opened

  • Start Time: 2021-05-04T09:28:01.619+0000

  • Duration: 141 min 27 sec

  • Commit: d4133b6

Test stats 🧪

Test Results
Failed 0
Passed 47168
Skipped 5246
Total 52414

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 47168
Skipped 5246
Total 52414

@v1v v1v merged commit badf982 into master May 4, 2021
@v1v v1v removed backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels May 4, 2021
@v1v v1v deleted the revert-25454-revert/google-storage-ext branch May 4, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout approved these changes

Assignees

@v1v v1v

Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @elasticmachine @cachedout