Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #25423 to 7.x: Do not use unversioned home with watcher binary path #25459

Merged
merged 3 commits into from
May 4, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 30, 2021

Cherry-pick of PR #25423 to 7.x branch. Original message:

What does this PR do?

The problem is when agent tries to invoke watcher which checks upgraded agent for failures and at the same time unversioned home path is set.

Usually agent took its home path which is {top_path}/data/elastic-agent-{hash}/elastic-agent and invoked watch sub-command on binary at that path.

When unversioned path is set it tries to run watcher from {top_path}/data/elastic-agent and as so it results in binary not found.

Fixes: #25371

Why is it important?

Reduce noise created by failng attempt to run this. This is just a case when running container sub-command which tempers paths.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

cc @michel-laterman

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 30, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25459 updated

  • Start Time: 2021-05-04T09:15:55.443+0000

  • Duration: 105 min 49 sec

  • Commit: be15fde

Test stats 🧪

Test Results
Failed 0
Passed 6733
Skipped 31
Total 6764

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6733
Skipped 31
Total 6764

@michalpristas michalpristas merged commit d773305 into elastic:7.x May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants