-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow role_arn work with access keys for AWS #25446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Apr 29, 2021
kaiyan-sheng
added
needs_backport
PR is waiting to be backported to other branches.
review
Team:Integrations
Label for the Integrations team
labels
Apr 29, 2021
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Apr 29, 2021
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kvch
reviewed
May 3, 2021
kvch
reviewed
May 3, 2021
kvch
approved these changes
May 3, 2021
6 tasks
kaiyan-sheng
added
v7.14.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
May 3, 2021
6 tasks
kaiyan-sheng
added a commit
that referenced
this pull request
May 4, 2021
kaiyan-sheng
added a commit
that referenced
this pull request
May 4, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to change
role_arn
config option to work not only with given credential profile but also access keys. With this change,aws
integration will be able to userole_arn
without volume mounting the credential profile file.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
With IAM role
test-role
setup, config below should work:Related issues
This PR also fixed the
role_arn
related documentation.