Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow role_arn work with access keys for AWS #25446

Merged
merged 5 commits into from
May 3, 2021
Merged

Allow role_arn work with access keys for AWS #25446

merged 5 commits into from
May 3, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 29, 2021

What does this PR do?

This PR is to change role_arn config option to work not only with given credential profile but also access keys. With this change, aws integration will be able to use role_arn without volume mounting the credential profile file.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

With IAM role test-role setup, config below should work:

metricbeat.modules:
- module: aws
  period: 5m
  access_key_id: xxx
  secret_access_key: yyy
  role_arn: arn:aws:iam::1234:role/test-role
  metricsets:
    - ec2

Related issues

This PR also fixed the role_arn related documentation.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 29, 2021
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Integrations Label for the Integrations team labels Apr 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25446 updated

  • Start Time: 2021-05-03T13:44:18.668+0000

  • Duration: 152 min 3 sec

  • Commit: f148d38

Test stats 🧪

Test Results
Failed 0
Passed 18975
Skipped 1577
Total 20552

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 18975
Skipped 1577
Total 20552

@kaiyan-sheng kaiyan-sheng merged commit 0f50230 into elastic:master May 3, 2021
@kaiyan-sheng kaiyan-sheng deleted the aws_arn branch May 3, 2021 18:02
@kaiyan-sheng kaiyan-sheng added v7.14.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 3, 2021
kaiyan-sheng added a commit that referenced this pull request May 4, 2021
kaiyan-sheng added a commit that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Clarify aws credentials required with role_arn
3 participants