[Filebeat] Add single quotes around configurable string values in O365 #25215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values passed in by users that are expected to be strings should be single-quoted. Also, this fixes the `tojson` function to not escape &, <, and > to to \u0026, \u003c, and \u003e. This caused problems if the value is an api keys or password that contained one of those characters. Fixes elastic#25058
andrewkroh
added
bug
review
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
approved these changes
Apr 22, 2021
|
/test |
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Values passed in by users that are expected to be strings should be single-quoted. Also, this fixes the `tojson` function to not escape &, <, and > to to \u0026, \u003c, and \u003e. This caused problems if the value is an api keys or password that contained one of those characters. Fixes #25058 (cherry picked from commit eed1cbb)
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Values passed in by users that are expected to be strings should be single-quoted. Also, this fixes the `tojson` function to not escape &, <, and > to to \u0026, \u003c, and \u003e. This caused problems if the value is an api keys or password that contained one of those characters. Fixes #25058 (cherry picked from commit eed1cbb)
andrewkroh
added a commit
that referenced
this pull request
Apr 23, 2021
…25231) Values passed in by users that are expected to be strings should be single-quoted. Also, this fixes the `tojson` function to not escape &, <, and > to to \u0026, \u003c, and \u003e. This caused problems if the value is an api keys or password that contained one of those characters. Fixes #25058 (cherry picked from commit eed1cbb) Co-authored-by: Andrew Kroh <[email protected]>
andrewkroh
added a commit
that referenced
this pull request
Apr 23, 2021
Values passed in by users that are expected to be strings should be single-quoted. Also, this fixes the `tojson` function to not escape &, <, and > to to \u0026, \u003c, and \u003e. This caused problems if the value is an api keys or password that contained one of those characters. Fixes #25058 (cherry picked from commit eed1cbb)
andrewkroh
added a commit
that referenced
this pull request
Apr 25, 2021
…5 (backport #25215) (#25232) * Add single quotes around configurable string values in O365 (#25215) Values passed in by users that are expected to be strings should be single-quoted. Also, this fixes the `tojson` function to not escape &, <, and > to to \u0026, \u003c, and \u003e. This caused problems if the value is an api keys or password that contained one of those characters. Fixes #25058 (cherry picked from commit eed1cbb) * Fix changelog Co-authored-by: Andrew Kroh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Values passed in by users that are expected to be strings should be single-quoted.
Also, this fixes the
tojsonfunction to not escape &, <, and > to to \u0026, \u003c, and \u003e. Thiscaused problems if the value is an api keys or password that contained one of those characters.
Fixes #25058
Why is it important?
We don't want to create arbitrary restrictions on the allowed characters in client secrets.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues