Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24636 to 7.x: [Filebeat] Change okta.target to nested field #24969

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 7, 2021

Cherry-pick of PR #24636 to 7.x branch. Original message:

What does this PR do?

Resolves #24354. Changes the okta.target field from an array to flattened type

Why is it important?

unable to perform nested searches on the fields without it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Resolves #24354

Use cases

Screenshots

Logs

#24354 (comment)

* Change okta.target to nested field

* update to flattened field type

* fixed test files

* update changelog

* Move changelog line to Added section

Co-authored-by: Marc Guasch <[email protected]>
(cherry picked from commit 803e8ca)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24969 opened

  • Start Time: 2021-04-07T13:27:57.471+0000

  • Duration: 62 min 3 sec

  • Commit: 1b2e7f1

Test stats 🧪

Test Results
Failed 0
Passed 13220
Skipped 2285
Total 15505

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13220
Skipped 2285
Total 15505

@marc-gr marc-gr merged commit 698df22 into elastic:7.x Apr 7, 2021
@marc-gr marc-gr deleted the backport_24636_7.x branch April 7, 2021 14:31
@zube zube bot removed the [zube]: Done label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants