Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s manifests to use proper roles' scope for leaderelection #24958

Merged

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Apr 7, 2021

What does this PR do?

This PR updates the roles required for using the leaderelection feature with lease Objects as lockObjects.

Why is it important?

To improve the access/privileges we use for leaderelection.

@ChrsMark ChrsMark added v7.13.0 kubernetes Enable builds in the CI for kubernetes labels Apr 7, 2021
@ChrsMark ChrsMark requested a review from jsoriano April 7, 2021 08:49
@ChrsMark ChrsMark self-assigned this Apr 7, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24958 updated

  • Start Time: 2021-04-07T11:18:39.723+0000

  • Duration: 68 min 55 sec

  • Commit: 28e24dc

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

ChrsMark added 3 commits April 7, 2021 13:33
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- coordination.k8s.io
resources:
- leases
verbs: ["get", "create", "update"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't delete also needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see now your comment in #24913 (comment) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kubernetes Enable builds in the CI for kubernetes Team:Integrations Label for the Integrations team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants