Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyberark Privileged Access Security module #24803

Merged
merged 102 commits into from
Apr 19, 2021
Merged

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 29, 2021

This PR adds a new module, cyberarkpas, to ingest Privileged Access Security audit logs from Vault via syslog.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Dashboard:

filebeat-cyberarkpas-overview

Logs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 29, 2021
@adriansr adriansr closed this Mar 29, 2021
@adriansr adriansr reopened this Mar 29, 2021
@adriansr adriansr marked this pull request as draft March 29, 2021 07:48
Copy link
Contributor Author

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes to reviewers.

Don't be overwhelmed by the size of the PR. Most of it are sample logs that I plan to reduce.

@@ -0,0 +1,161 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is necessary to configure the Vault, but it's not used by the module. Added it here so that it's under version control. We need to see how to distribute it.

x-pack/filebeat/module/cyberarkpas/audit/_meta/fields.yml Outdated Show resolved Hide resolved

processors:
#
# Set ECS event.ingested
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Most of these comments can be moved to a description field.

#
- script:
lang: painless
params:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: Please review these mappings

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24803 updated

  • Start Time: 2021-04-19T20:17:50.518+0000

  • Duration: 69 min 43 sec

  • Commit: d739863

Test stats 🧪

Test Results
Failed 0
Passed 13608
Skipped 2271
Total 15879

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13608
Skipped 2271
Total 15879

@adriansr adriansr force-pushed the cyberarkpas branch 3 times, most recently from 727eb7d to 2a461e5 Compare April 6, 2021 09:50
@adriansr adriansr added review backport-v7.13.0 Automated backport with mergify and removed in progress Pull request is currently in progress. labels Apr 15, 2021
@adriansr adriansr marked this pull request as ready for review April 15, 2021 14:48
@adriansr adriansr changed the title [WIP] Cyberark Privileged Account Security module Cyberark Privileged Access Security module Apr 15, 2021
@adriansr
Copy link
Contributor Author

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks documenting the pipeline so well!

target: ''
fields:
ecs.version: 1.8.0
# TODO: internal/external zones
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for adding network_direction? We do have that available in Ingest Node too now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added the ingest node processor. However, I don't see a way for the user to pass custom internal networks in a way that's compatible with packages. Any ideas?

Technically it should escape all control characters (0-0x1f) but
I can't find a way to do that in XSLT v1.0. Only TAB, CR and LF
can be represented.
@adriansr adriansr merged commit 2d51864 into elastic:master Apr 19, 2021
mergify bot pushed a commit that referenced this pull request Apr 19, 2021
This PR adds a new module, cyberarkpas, to ingest Privileged Access Security audit logs from Vault via syslog.

(cherry picked from commit 2d51864)
v1v added a commit to v1v/beats that referenced this pull request Apr 20, 2021
…-github-pr-comment-template

* upstream/master:
  [Ingest Manager] Keep http and logging config during enroll (elastic#25132)
  Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742)
  [libbeat] New decode xml wineventlog processor (elastic#25115)
  Add svc to agent k8s clusterRole (elastic#25146)
  Add awsfargate module to collect container logs from Amazon ECS on Fargate (elastic#25041)
  [Filebeat][Cisco ASA] log enhancement and performance (elastic#24744)
  Watch kubernetes namespaces for autodiscover metadata for pods (elastic#25117)
  Cyberark Privileged Access Security module (elastic#24803)
  [Elastic Agent] Log the container command output with LOGS_PATH (elastic#25150)
  Fix for tests after `device...` field has been removed (elastic#25141)
  [Ingest Manager] Restart process on output change (elastic#24907)
  Set --insecure in container when FLEET_SERVER_ENABLE and FLEET_INSECURE set. (elastic#25137)
  [filebeat] Update documentation / changelog / beta warnings for the syslog input (elastic#25047)
  Add support for ignore_inactive in filestream input (elastic#25036)
  Fix bug with annotations dedot config on k8s not used (elastic#25111)
adriansr pushed a commit that referenced this pull request Apr 20, 2021
This PR adds a new module, cyberarkpas, to ingest Privileged Access Security audit logs from Vault via syslog.

(cherry picked from commit 2d51864)
adriansr added a commit to elastic/integrations that referenced this pull request May 12, 2021
Adds a new package, cyberarkpas, for Cyberark Privileged Access Security audit logs (from elastic/beats#24803)
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…ic#928)

Adds a new package, cyberarkpas, for Cyberark Privileged Access Security audit logs (from elastic/beats#24803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.13.0 Automated backport with mergify enhancement Filebeat Filebeat review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants