Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24760 to 7.x: Fix nil pointer for nil list item #24765

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Mar 25, 2021

Cherry-pick of PR #24760 to 7.x branch. Original message:

What does this PR do?

This PR guards against a nil items which are part of the list. Fn call then casues agent to panic.

Why is it important?

Fixes: #23734

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Ingest Manager] Fix nil pointer for nil list item (elastic#24760)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 25, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24765 opened

  • Start Time: 2021-03-25T14:49:27.098+0000

  • Duration: 69 min 1 sec

  • Commit: 531e5c3

Test stats 🧪

Test Results
Failed 0
Passed 6532
Skipped 24
Total 6556

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6532
Skipped 24
Total 6556

@michalpristas michalpristas merged commit 29584fe into elastic:7.x Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants