Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Refactor: remove deadcode #24715

Merged
merged 9 commits into from
Mar 24, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Mar 23, 2021

What does this PR do?

Removes deadcode and fixes some issues raised by static check.

Why is it important?

Readability

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 23, 2021
@botelastic
Copy link

botelastic bot commented Mar 23, 2021

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like all the RED!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24715 opened

  • Start Time: 2021-03-23T17:41:51.776+0000

  • Duration: 52 min 4 sec

  • Commit: 8647315

Test stats 🧪

Test Results
Failed 0
Passed 6588
Skipped 16
Total 6604

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6588
Skipped 16
Total 6604

@michalpristas
Copy link
Contributor Author

/package

@michalpristas michalpristas merged commit 01eb297 into elastic:master Mar 24, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Mar 25, 2021
michalpristas added a commit that referenced this pull request Mar 26, 2021
[Ingest Manager] Refactor: remove deadcode (#24715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants