[Heartbeat] Zip URL Support #24714
Merged
[Heartbeat] Zip URL Support #24714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
enhancement
Heartbeat
Team:obs-ds-hosted-services
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
vigneshshanmugam
force-pushed
the
zipurl
branch
from
0a0a19c to
d1c0917
Compare
|
Pinging @elastic/uptime (Team:Uptime) |
vigneshshanmugam
approved these changes
Apr 23, 2021
| err = unzipFile(targetDir, folder, f) | ||
| if err != nil { | ||
| // TODO: err handlers | ||
| os.RemoveAll(targetDir) |
There was a problem hiding this comment.
This feels unnecessary right? we already remove the directory when unzip returns error.
| ) | ||
|
|
||
| func TestZipUrlFetchNoAuth(t *testing.T) { | ||
| address, teardown := setupTests() |
There was a problem hiding this comment.
I thought doing this for every test was a overkill which is why i moved up everything in to functions and called them from a global test function. I guess it's not? Just a question though.
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Apr 23, 2021
Adds support for remote zips to browser monitors, letting users just automatically pull from a remote repo. Fixes elastic/uptime#271
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Apr 23, 2021
Adds support for remote zips to browser monitors, letting users just automatically pull from a remote repo. Fixes elastic/uptime#271
andrewvc
added a commit
that referenced
this pull request
Apr 23, 2021
Adds support for remote zips to browser monitors, letting users just automatically pull from a remote repo. Fixes elastic/uptime#271
|
@andrewvc One of the new tests in the PR is panicking in master. |
andrewvc
added a commit
that referenced
this pull request
Apr 23, 2021
* [Heartbeat] Zip URL Support (#24714) Adds support for remote zips to browser monitors, letting users just automatically pull from a remote repo. Fixes elastic/uptime#271 * Fix null check * Add missing test
|
@andrewkroh fixed it in #25288 , apologies for the flakiness! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for remote zips to browser monitors, letting users just automatically pull from a remote repo.
Fixes elastic/uptime#271
Why is it important?
Checklist
- [ ] I have made corresponding changes to the documentationCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs