[Filebeat] Fix date parsing in GSuite/Google Workspace modules #24696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
Filebeat
botelastic
bot
added
the
needs_team
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
@andrewkroh Looks like this same fix is needed https://github.com/elastic/beats/blob/d427453a9f311e00f91354da03fd3bbb99d82e50/x-pack/filebeat/module/google_workspace/login/config/pipeline.js#L67 to resolve #24692 |
andrewkroh
changed the title
The format of Date#toUTCString was incompatible with the format accepted by Elasticsearch by default. By writing a Date object from the JS pipeline this becomes a time.Time in the event that is formatted by common.Time when going out as JSON. Fixes elastic#24694
andrewkroh
force-pushed
the
bugfix/fb/gsuite-login-date
branch
from
954e99f to
a3f22c0
Compare
marc-gr
approved these changes
Mar 23, 2021
|
run tests |
Merged
3 tasks
andrewkroh
removed
the
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Mar 24, 2021
…ic#24696) * Fix date parsing in GSuite/login fileset The format of Date#toUTCString was incompatible with the format accepted by Elasticsearch by default. By writing a Date object from the JS pipeline this becomes a time.Time in the event that is formatted by common.Time when going out as JSON. Fixes elastic#24694 * Apply fix to google_workspace Fixes elastic#24692 (cherry picked from commit a4a3ff0)
Merged
3 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Mar 24, 2021
…ic#24696) * Fix date parsing in GSuite/login fileset The format of Date#toUTCString was incompatible with the format accepted by Elasticsearch by default. By writing a Date object from the JS pipeline this becomes a time.Time in the event that is formatted by common.Time when going out as JSON. Fixes elastic#24694 * Apply fix to google_workspace Fixes elastic#24692 (cherry picked from commit a4a3ff0)
andrewkroh
added a commit
that referenced
this pull request
Mar 24, 2021
… (#24735) * Fix date parsing in GSuite/login fileset The format of Date#toUTCString was incompatible with the format accepted by Elasticsearch by default. By writing a Date object from the JS pipeline this becomes a time.Time in the event that is formatted by common.Time when going out as JSON. Fixes #24694 * Apply fix to google_workspace Fixes #24692 (cherry picked from commit a4a3ff0)
andrewkroh
added a commit
that referenced
this pull request
Mar 24, 2021
… (#24736) * Fix date parsing in GSuite/login fileset The format of Date#toUTCString was incompatible with the format accepted by Elasticsearch by default. By writing a Date object from the JS pipeline this becomes a time.Time in the event that is formatted by common.Time when going out as JSON. Fixes #24694 * Apply fix to google_workspace Fixes #24692 (cherry picked from commit a4a3ff0)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ic#24696) (elastic#24736) * Fix date parsing in GSuite/login fileset The format of Date#toUTCString was incompatible with the format accepted by Elasticsearch by default. By writing a Date object from the JS pipeline this becomes a time.Time in the event that is formatted by common.Time when going out as JSON. Fixes elastic#24694 * Apply fix to google_workspace Fixes elastic#24692 (cherry picked from commit 2a63518)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The format of Date#toUTCString was incompatible with the format accepted by Elasticsearch by default.
By writing a Date object from the JS pipeline this becomes a time.Time in the event that is formatted by
common.Time when going out as JSON.
Fixes #24694
Fixes #24692
Why is it important?
Fixes data ingesting exceptions and prevents event loss.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues