Improve support for log_statement and log_duration in PostgreSQL module #24607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
enhancement
module
Filebeat
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
20 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
/test |
sayden
reviewed
Mar 24, 2021
sayden
approved these changes
Mar 24, 2021
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 30, 2021
…le (elastic#24607) Provide a better experience with a variety of logging settings: * Pipeline parses statement durations when statement is not included in the log line. * Pipeline parses statements when duration is not included in the log line. * Query duration dashboard partially works now when events include durations but no statements. * Queries in dashboards filter per `event.dataset: postgresql.log` for better performance. (cherry picked from commit d00dd45)
6 tasks
jsoriano
removed
the
needs_backport
jsoriano
added a commit
that referenced
this pull request
Mar 30, 2021
…le (#24607) (#24841) Provide a better experience with a variety of logging settings: * Pipeline parses statement durations when statement is not included in the log line. * Pipeline parses statements when duration is not included in the log line. * Query duration dashboard partially works now when events include durations but no statements. * Queries in dashboards filter per `event.dataset: postgresql.log` for better performance. (cherry picked from commit d00dd45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
event.dataset: postgresql.logfor better performance.Why is it important?
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationSee Add docs about PostgreSQL monitoring #24588.I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Use cases
Module works better now when logs include lines generated by statements when
log_statementis used and/orlog_min_duration_statementis not used, giving a better initial experience in some cases, and allowing different options to configure PostgreSQL and still get relevant data.