Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set event.type for Packetbeat flow events #24564

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 16, 2021

What does this PR do?

Add event.type: [connection] to flow events and include end for final flows.

Why is it important?

This helps the data comply to ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

  "event": {
    "type": [
      "connection",
      "end"
    ],
    "start": "2021-03-16T15:14:29.826Z",
    "end": "2021-03-16T15:14:29.826Z",
    "duration": 273694,
    "dataset": "flow",
    "kind": "event",
    "category": [
      "network"
    ],
    "action": "network_flow"
  }

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 16, 2021
@botelastic
Copy link

botelastic bot commented Mar 16, 2021

This pull request doesn't have a Team:<team> label.

Add `event.type: [connection]` to flow events and include `end` for final flows.
@andrewkroh andrewkroh force-pushed the feature/pb/event-type-flows branch from f7c9c36 to 5599980 Compare March 16, 2021 15:54
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24564 updated

  • Start Time: 2021-03-16T15:55:31.248+0000

  • Duration: 44 min 45 sec

  • Commit: 5599980

Test stats 🧪

Test Results
Failed 0
Passed 4906
Skipped 45
Total 4951

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4906
Skipped 45
Total 4951

@andrewkroh andrewkroh merged commit 7f35a78 into elastic:master Mar 18, 2021
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Mar 18, 2021
Add `event.type: [connection]` to flow events and include `end` for final flows.

(cherry picked from commit 7f35a78)
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Mar 18, 2021
Add `event.type: [connection]` to flow events and include `end` for final flows.

(cherry picked from commit 7f35a78)
andrewkroh added a commit that referenced this pull request Mar 18, 2021
Add `event.type: [connection]` to flow events and include `end` for final flows.

(cherry picked from commit 7f35a78)
andrewkroh added a commit that referenced this pull request Mar 18, 2021
Add `event.type: [connection]` to flow events and include `end` for final flows.

(cherry picked from commit 7f35a78)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
)

Add `event.type: [connection]` to flow events and include `end` for final flows.

(cherry picked from commit f626a08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants