Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24429 to 7.12: [Elastic Agent] Improve Endpoint installation logging #24439

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Mar 9, 2021

Cherry-pick of PR #24429 to 7.12 branch. Original message:

What does this PR do?

Improves the logging of the installation process for Endpoint Security. Now when Endpoint Security fails to install or uninstall the output of the command will be provided in the error message.

Why is it important?

So when Endpoint Security fails to install it is easier to debug what occurred.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

* Improve logging of exec_file_step.

* Add --log stderr to endpoint.

* Add changelog.

(cherry picked from commit 8efc24c)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 9, 2021
@blakerouse blakerouse self-assigned this Mar 9, 2021
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backports looks good

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 9, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24439 updated

  • Start Time: 2021-03-09T14:32:32.673+0000

  • Duration: 59 min 25 sec

  • Commit: 2864c0f

Test stats 🧪

Test Results
Failed 0
Passed 6532
Skipped 24
Total 6556

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6532
Skipped 24
Total 6556

@blakerouse blakerouse merged commit d1b675b into elastic:7.12 Mar 9, 2021
@blakerouse blakerouse deleted the backport_24429_7.12 branch March 9, 2021 15:35
@zube zube bot removed the [zube]: Done label Jun 8, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…elastic#24439)

* Improve logging of exec_file_step.

* Add --log stderr to endpoint.

* Add changelog.

(cherry picked from commit 24799c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants