Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24387 to 7.12: Fix failing installation on windows 7 #24411

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Mar 8, 2021

Cherry-pick of PR #24387 to 7.12 branch. Original message:

What does this PR do?

Issue described here: #24327
there was a race between enrollment process and restarting service, FS playing part as well.
The thing was that when agent was restarted only on windows 7 it loaded standalone ID, even though it was already replaced by enrollment process.
Then when agent retrieved hosts from fleet it even overwrote updated ID with stale one.

This fix adds a lock which prevents simultaneous write in between these two processes and a forced Reload in case of fleet managed agent later in the cycle.
Another thing is FSync after file rotation which was missing for windows.

These seems to fix the issue, tested on win 7 VM on cloud

Why is it important?

Fixes #24327

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 8, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24411 updated

  • Start Time: 2021-03-09T12:38:40.539+0000

  • Duration: 54 min 21 sec

  • Commit: f8a9845

Test stats 🧪

Test Results
Failed 0
Passed 46002
Skipped 4973
Total 50975

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46002
Skipped 4973
Total 50975

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 78e8afa into elastic:7.12 Mar 9, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants