[kubernetes][metricbeat]correct args system.hostfs

[shugotek]

Error on args system.hostfs, second - is missing

What does this PR do?

This is a fix for #23267.
In current kubernetes deployment, yaml file for metricbeat forget a second -

Why is it important?

Without that, args system.hostfs not use

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Monitoring: allow specifying /proc or hostfs path. #23267

[cla-checker-service]

💚 CLA has been signed

[elasticmachine]

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Pull request #24393 opened

• Reason: The PR is not allowed to run in the CI yet

• Start Time: 2021-03-05T15:26:42.010+0000

• Duration: 5 min 50 sec

• Commit: d86d37e

Trends 🧪

Steps errors

Expand to view the steps failures

Load a resource file from a shared library

• Took 0 min 0 sec . View more details on here
• Description: approval-list/elastic/beats.yml

Error signal

• Took 0 min 0 sec . View more details on here
• Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output

Expand to view the last 100 lines of log output

[2021-03-05T15:29:16.847Z]  > git remote # timeout=10
[2021-03-05T15:29:16.851Z]  > git config --get remote.origin.url # timeout=10
[2021-03-05T15:29:16.855Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-03-05T15:29:16.858Z]  > git merge ee40f6f8ac36f800bbeb026f9396547ab4cec1d4 # timeout=10
[2021-03-05T15:29:16.867Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-03-05T15:29:16.879Z]  > git config core.sparsecheckout # timeout=10
[2021-03-05T15:29:16.882Z]  > git checkout -f d86d37ed76cd52e71557402ee63311d9614e64cd # timeout=15
[2021-03-05T15:29:21.610Z] Commit message: "correct args system.hostfs"
[2021-03-05T15:29:21.611Z] First time build. Skipping changelog.
[2021-03-05T15:29:21.611Z] Cleaning workspace
[2021-03-05T15:29:21.816Z]  > git --version # timeout=10
[2021-03-05T15:29:21.819Z]  > git --version # 'git version 2.17.1'
[2021-03-05T15:29:21.822Z] fatal: bad object 636761566722d814af1d42740fd53a737f925a59
[2021-03-05T15:29:21.612Z]  > git rev-parse --verify HEAD # timeout=10
[2021-03-05T15:29:21.616Z] Resetting working tree
[2021-03-05T15:29:21.616Z]  > git reset --hard # timeout=10
[2021-03-05T15:29:21.697Z]  > git clean -fdx # timeout=10
[2021-03-05T15:29:22.654Z] Timeout set to expire in 3 hr 0 min
[2021-03-05T15:29:22.683Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-03-05T15:29:22.929Z] [INFO] Number of builds to be searched 10
[2021-03-05T15:29:23.674Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-03-05T15:29:23.702Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-24393/src/github.com/elastic/beats
[2021-03-05T15:29:23.748Z] [INFO] gitCheckout: Checkout SCM PR-24393 with default customisation from the Item.
[2021-03-05T15:29:23.785Z] [INFO] Override default checkout
[2021-03-05T15:29:23.855Z] Sleeping for 10 sec
[2021-03-05T15:29:34.148Z] The recommended git tool is: git
[2021-03-05T15:29:34.194Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-03-05T15:29:34.253Z] Wiping out workspace first.
[2021-03-05T15:29:34.261Z] Cloning the remote Git repository
[2021-03-05T15:29:34.262Z] Using shallow clone with depth 10
[2021-03-05T15:29:34.262Z] Avoid fetching tags
[2021-03-05T15:29:34.277Z] Cloning repository [email protected]:elastic/beats.git
[2021-03-05T15:29:34.308Z]  > git init /var/lib/jenkins/workspace/Beats_beats_PR-24393/src/github.com/elastic/beats # timeout=10
[2021-03-05T15:29:34.313Z] Fetching upstream changes from [email protected]:elastic/beats.git
[2021-03-05T15:29:34.313Z]  > git --version # timeout=10
[2021-03-05T15:29:34.317Z]  > git --version # 'git version 2.17.1'
[2021-03-05T15:29:34.317Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-03-05T15:29:34.322Z]  > git fetch --no-tags --progress -- [email protected]:elastic/beats.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-03-05T15:29:53.505Z] Cleaning workspace
[2021-03-05T15:29:53.519Z] Using shallow fetch with depth 10
[2021-03-05T15:29:53.519Z] Pruning obsolete local branches
[2021-03-05T15:29:53.446Z]  > git config remote.origin.url [email protected]:elastic/beats.git # timeout=10
[2021-03-05T15:29:53.449Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-03-05T15:29:53.500Z]  > git config remote.origin.url [email protected]:elastic/beats.git # timeout=10
[2021-03-05T15:29:53.507Z]  > git rev-parse --verify HEAD # timeout=10
[2021-03-05T15:29:53.510Z] No valid HEAD. Skipping the resetting
[2021-03-05T15:29:53.510Z]  > git clean -fdx # timeout=10
[2021-03-05T15:29:53.520Z] Fetching upstream changes from [email protected]:elastic/beats.git
[2021-03-05T15:29:53.520Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-03-05T15:29:53.524Z]  > git fetch --no-tags --progress --prune -- [email protected]:elastic/beats.git +refs/pull/24393/head:refs/remotes/origin/PR-24393 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-03-05T15:29:54.492Z] Merging remotes/origin/master commit ee40f6f8ac36f800bbeb026f9396547ab4cec1d4 into PR head commit d86d37ed76cd52e71557402ee63311d9614e64cd
[2021-03-05T15:29:54.494Z]  > git config core.sparsecheckout # timeout=10
[2021-03-05T15:29:54.499Z]  > git checkout -f d86d37ed76cd52e71557402ee63311d9614e64cd # timeout=15
[2021-03-05T15:29:56.071Z] Merge succeeded, producing d86d37ed76cd52e71557402ee63311d9614e64cd
[2021-03-05T15:29:56.071Z] Checking out Revision d86d37ed76cd52e71557402ee63311d9614e64cd (PR-24393)
[2021-03-05T15:29:57.678Z] Commit message: "correct args system.hostfs"
[2021-03-05T15:29:57.678Z] Cleaning workspace
[2021-03-05T15:29:56.041Z]  > git remote # timeout=10
[2021-03-05T15:29:56.045Z]  > git config --get remote.origin.url # timeout=10
[2021-03-05T15:29:56.048Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-03-05T15:29:56.051Z]  > git merge ee40f6f8ac36f800bbeb026f9396547ab4cec1d4 # timeout=10
[2021-03-05T15:29:56.063Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-03-05T15:29:56.076Z]  > git config core.sparsecheckout # timeout=10
[2021-03-05T15:29:56.079Z]  > git checkout -f d86d37ed76cd52e71557402ee63311d9614e64cd # timeout=15
[2021-03-05T15:29:57.682Z]  > git rev-parse --verify HEAD # timeout=10
[2021-03-05T15:29:57.686Z] Resetting working tree
[2021-03-05T15:29:57.686Z]  > git reset --hard # timeout=10
[2021-03-05T15:29:57.868Z]  > git --version # timeout=10
[2021-03-05T15:29:57.872Z]  > git --version # 'git version 2.17.1'
[2021-03-05T15:29:57.875Z] fatal: bad object 636761566722d814af1d42740fd53a737f925a59
[2021-03-05T15:29:57.766Z]  > git clean -fdx # timeout=10
[2021-03-05T15:30:00.667Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-03-05T15:30:01.618Z] + git fetch https://****:****@github.com/elastic/beats.git +refs/pull/*/head:refs/remotes/origin/pr/*
[2021-03-05T15:31:09.864Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-24393/src/github.com/elastic/beats/.git
[2021-03-05T15:31:10.070Z] Archiving artifacts
[2021-03-05T15:31:11.512Z] + git rev-parse HEAD
[2021-03-05T15:31:11.938Z] + git rev-parse HEAD
[2021-03-05T15:31:12.259Z] + git rev-parse origin/pr/24393
[2021-03-05T15:31:12.322Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-03-05T15:31:12.661Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-03-05T15:31:13.764Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/beats/pulls/24393/reviews return 0 elements
[2021-03-05T15:31:13.855Z] [INFO] githubPrCheckApproved: Title: [kubernetes][metricbeat]correct args system.hostfs - User: shugotek - Author Association: FIRST_TIME_CONTRIBUTOR
[2021-03-05T15:31:14.775Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-03-05T15:31:14.775Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-03-05T15:31:14.972Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-03-05T15:31:15.015Z] Sleeping for 5 sec
[2021-03-05T15:31:16.205Z] Stage "Lint" skipped due to earlier failure(s)
[2021-03-05T15:31:16.304Z] Stage "Build&Test" skipped due to earlier failure(s)
[2021-03-05T15:31:16.403Z] Stage "Packaging" skipped due to earlier failure(s)
[2021-03-05T15:31:16.546Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-24393/src/github.com/elastic/beats
[2021-03-05T15:31:29.980Z] Click here to forcibly terminate running steps
[2021-03-05T15:31:31.006Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-24393
[2021-03-05T15:31:31.172Z] [INFO] getVaultSecret: Getting secrets
[2021-03-05T15:31:31.312Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-03-05T15:31:32.478Z] + chmod 755 generate-build-data.sh
[2021-03-05T15:31:32.478Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24393/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24393/runs/1 ABORTED 290192
[2021-03-05T15:31:32.728Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24393/runs/1/steps/?limit=10000 -o steps-info.json
[2021-03-05T15:31:33.653Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24393/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-03-05T15:31:33.904Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-03-05T15:31:34.834Z] Retry 2/3 exited 22, retrying in 2 seconds...

[elasticmachine]

Pinging @elastic/integrations (Team:Integrations)

[andresrc]

ping @ChrsMark

[ChrsMark]

I think flag is correct 🤔 , see https://www.elastic.co/guide/en/beats/metricbeat/current/running-on-docker.html#monitoring-host.

There is already a fix (#24334) for #23267.

[shugotek]

If i check on metricbeat command line and if i verify doc, it's not correct, see in "flags" subpart https://www.elastic.co/guide/en/beats/metricbeat/current/command-line-options.html#run-command

[ChrsMark]

Well, One or two minus signs may be used; they are equivalent see https://golang.org/pkg/flag/#hdr-Command_line_flag_syntax.

So this PR doesn't actually fix/change anything, no? I also verified by running manually Metricbeat from inside a Pod and using both options work.

Do you think there is anything else here we need to check?

[mergify]

This pull request does not have a backport label. Could you fix it @shugotek? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.