-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker][elastic-agent] use Default policy for enrollment #24385
Conversation
If no policy specified, fall back to default policy.
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Pinging @elastic/agent (Team:Agent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is doing it the same way as bash was doing it. That is the wrong way to do this. Kibana marks the default policy with is_default
. The code already uses that to find the correct policy.
See the findPolicy
function in container.go
.
I ran into a |
Related to changes from #24220. If an agent should be enrolled to the default policy, do not put the burden of knowing the default policy name on the user, but fall back to the default policy automatically.