Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker][elastic-agent] use Default policy for enrollment #24385

Closed
wants to merge 1 commit into from

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Mar 5, 2021

Related to changes from #24220. If an agent should be enrolled to the default policy, do not put the burden of knowing the default policy name on the user, but fall back to the default policy automatically.

If no policy specified, fall back to default policy.
@simitt simitt added enhancement Team:Fleet Label for the Fleet team labels Mar 5, 2021
@simitt simitt requested a review from blakerouse March 5, 2021 13:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24385 opened

  • Start Time: 2021-03-05T13:45:17.285+0000

  • Duration: 68 min 10 sec

  • Commit: ab2edfc

Test stats 🧪

Test Results
Failed 0
Passed 6548
Skipped 16
Total 6564

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6548
Skipped 16
Total 6564

@andresrc andresrc added Team:Elastic-Agent Label for the Agent team and removed Team:Fleet Label for the Fleet team Team:Ingest Management labels Mar 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing it the same way as bash was doing it. That is the wrong way to do this. Kibana marks the default policy with is_default. The code already uses that to find the correct policy.

See the findPolicy function in container.go.

@simitt
Copy link
Contributor Author

simitt commented Mar 8, 2021

I ran into a Error: unable to find policy named "" error without specifying the policy name. But this was due to Kibana not having the Fleet Server setup enabled by default; was merged with elastic/kibana#92422 and should be resolved with the next succesful snapshot build. Thanks.

@simitt simitt closed this Mar 8, 2021
@simitt simitt deleted the docker-use-default=policy branch July 16, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants