Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add resilience when ephemeral windows workers are reused #24316

Merged
merged 3 commits into from
Mar 3, 2021
Merged

CI: add resilience when ephemeral windows workers are reused #24316

merged 3 commits into from
Mar 3, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 3, 2021

What does this PR do?

  • Skip deleteDir for windows since those workers are ephemeral.
  • Create a unique workspace

Why is it important?

  • As long as the provisioner does not resolve the issue with reusing workspace we need to put some self-defense code in place
  • As long as the build system does not change the permissions to write only we are affected by the above reused workers.

Issues

#24284

@v1v v1v requested a review from a team as a code owner March 3, 2021 12:56
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 3, 2021
@v1v v1v self-assigned this Mar 3, 2021
cachedout
cachedout approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the sort of thing I was hoping for! Nicely done!

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 3, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24316 updated

  • Start Time: 2021-03-03T16:17:08.193+0000

  • Duration: 49 min 52 sec

  • Commit: 7c812d9

Test stats 🧪

Test Results
Failed 0
Passed 50672
Skipped 5500
Total 56172

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 50672
Skipped 5500
Total 56172

@v1v v1v added the macOS Enable builds in the CI for darwin testing label Mar 3, 2021
@v1v v1v merged commit 024dd5c into elastic:master Mar 3, 2021
@v1v v1v deleted the feature/remove-deletedir-in-windows branch March 3, 2021 18:34
v1v added a commit to v1v/beats that referenced this pull request Mar 3, 2021
@v1v
CI: add resilience when ephemeral windows workers are reused (elastic…
95423a2 
…#24316)
@v1v v1v mentioned this pull request Mar 3, 2021
Merged
v1v added a commit to v1v/beats that referenced this pull request Mar 3, 2021
@v1v
CI: add resilience when ephemeral windows workers are reused (elastic…
6bd6adb 
…#24316)
This was referenced Mar 3, 2021
Merged
Merged
v1v added a commit to v1v/beats that referenced this pull request Mar 3, 2021
@v1v
CI: add resilience when ephemeral windows workers are reused (elastic…
260e151 
…#24316)

# Conflicts:
#	Jenkinsfile
v1v added a commit that referenced this pull request Mar 4, 2021
@v1v
CI: add resilience when ephemeral windows workers are reused (#24316) (…
4190249 
…#24324)
v1v added a commit that referenced this pull request Mar 4, 2021
@v1v
CI: add resilience when ephemeral windows workers are reused (#24316) (…
24799ff 
…#24325)
v1v added a commit that referenced this pull request Mar 4, 2021
@v1v
CI: add resilience when ephemeral windows workers are reused (#24316) (…
1d9cced 
…#24326)
@v1v v1v mentioned this pull request Mar 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@cachedout cachedout cachedout approved these changes

Assignees

@v1v v1v

Labels
macOS Enable builds in the CI for darwin testing Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @elasticmachine @cachedout @kuisathaverat