Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Fix #24273 - Fix SIGSEGV due to missing err check #24281

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Mar 1, 2021

What does this PR do?

Fixes a missing checkout for an error when performing bootstrap of Fleet Server.

Why is it important?

So proper error is reported and to not cause a SIGSEGV.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added the Team:Fleet Label for the Fleet team label Mar 1, 2021
@blakerouse blakerouse self-assigned this Mar 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Member

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24281 opened

  • Start Time: 2021-03-01T19:36:43.461+0000

  • Duration: 52 min 50 sec

  • Commit: d199780

Test stats 🧪

Test Results
Failed 0
Passed 6548
Skipped 16
Total 6564

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6548
Skipped 16
Total 6564

@andresrc andresrc added Team:Elastic-Agent Label for the Agent team and removed Team:Fleet Label for the Fleet team labels Mar 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@blakerouse blakerouse merged commit a529338 into elastic:master Mar 1, 2021
@blakerouse blakerouse deleted the fix-24273 branch March 1, 2021 21:23
blakerouse added a commit to blakerouse/beats that referenced this pull request Mar 1, 2021
blakerouse added a commit that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic Agent crashes while trying to start the agent with Fleet Server
4 participants