Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23849 to 7.x: management.Status constants could not be used directly in log #23861

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Cherry-pick #23849 to 7.x: management.Status constants could not be used directly in log #23861

merged 2 commits into from
Feb 5, 2021

Conversation

ph
Copy link
Contributor

@ph ph commented Feb 4, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23849 to 7.x branch. Original message:

This add a stringer generator to the Status const to allow them to be
understood by a human in log.

ref: #23812

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
management.Status constants could not be used directly in log (elasti…
1e14193 
…c#23849)

* management.Status constants could not be used directly in log

This add stringer generator to the Status const to allow them to be
understood by a human in log.

ref: elastic#23812
(cherry picked from commit a52c744)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 4, 2021
@ph ph added the review label Feb 4, 2021
blakerouse
blakerouse approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good, minus the one comment.

x-pack/elastic-agent/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23861 updated

    • Start Time: 2021-02-05T13:39:10.749+0000

  • Duration: 49 min 6 sec

  • Commit: 38c0e8f

Test stats 🧪

Test Results
Failed 0
Passed 45383
Skipped 4775
Total 50158

Steps errors 1

Expand to view the steps failures

packetbeat-windows-8-windows-8 - Install Go/Mage/Python 1.15.7
  • Took 0 min 7 sec . View more details on here
  • Description: .ci/scripts/install-tools.bat

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 45383
Skipped 4775
Total 50158

@ph ph merged commit 2087f85 into elastic:7.x Feb 5, 2021
@zube zube bot removed the [zube]: Done label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees
No one assigned
Labels
backport review Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @blakerouse