Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run make notice linting #23553

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 18, 2021

What does this PR do?

@jsoriano pointed that the make check didn't run when go.mod changes:

Beats keep a NOTICE.txt file with references to the copyright statements of third party libraries.
This file should be up-to-date with the libraries used, for that, CI should be able to detect changes in dependencies so we don't forget to update this file, and it used to.
Recently a new dependency was added in #23484 (or #22541), without updating the NOTICE.txt file, and CI didn't detect it. We found the issue when it was detected in other PRs like #23536. This was fixed in #23549.
So it seems that this is being detected in some PRs and not in others, we should be able to prevent these issues in CI as they can be important for license compliance, and to prevent us including dependencies on software with forbidden licenses.

Why is it important?

Ensure there are no missing licenses in the NOTICE.txt file.

@v1v v1v added automation Team:Automation Label for the Observability productivity team v7.11.0 v7.12.0 labels Jan 18, 2021
@v1v v1v requested review from jsoriano and a team January 18, 2021 18:19
@v1v v1v self-assigned this Jan 18, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 18, 2021
Jenkinsfile Outdated Show resolved Hide resolved
@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Jan 18, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23553 updated

    • Start Time: 2021-01-19T09:11:51.365+0000
  • Duration: 48 min 49 sec

  • Commit: fa105b7

Test stats 🧪

Test Results
Failed 0
Passed 17287
Skipped 1346
Total 18633

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17287
Skipped 1346
Total 18633

@v1v v1v changed the title [CI] Run make check when go.mod or LICENSE.txt changes [CI] Run make notice linting Jan 19, 2021
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@v1v v1v merged commit 5978dad into elastic:master Jan 19, 2021
@v1v v1v deleted the feature/run-make-check-when-changes-go.mod branch January 19, 2021 10:19
v1v added a commit to v1v/beats that referenced this pull request Jan 19, 2021
v1v added a commit to v1v/beats that referenced this pull request Jan 19, 2021
v1v added a commit to v1v/beats that referenced this pull request Jan 19, 2021
v1v added a commit that referenced this pull request Jan 19, 2021
v1v added a commit that referenced this pull request Jan 19, 2021
v1v added a commit that referenced this pull request Jan 19, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation needs_backport PR is waiting to be backported to other branches. Team:Automation Label for the Observability productivity team v7.11.0 v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants