-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Run make notice linting #23553
Merged
v1v
merged 3 commits into
elastic:master
from
v1v:feature/run-make-check-when-changes-go.mod
Jan 19, 2021
Merged
[CI] Run make notice linting #23553
v1v
merged 3 commits into
elastic:master
from
v1v:feature/run-make-check-when-changes-go.mod
Jan 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
added
automation
Team:Automation
Label for the Observability productivity team
v7.11.0
v7.12.0
labels
Jan 18, 2021
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jan 18, 2021
jsoriano
reviewed
Jan 18, 2021
jsoriano
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Jan 18, 2021
cachedout
approved these changes
Jan 18, 2021
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kuisathaverat
approved these changes
Jan 19, 2021
v1v
changed the title
[CI] Run make check when go.mod or LICENSE.txt changes
[CI] Run make notice linting
Jan 19, 2021
jsoriano
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jan 19, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jan 19, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jan 19, 2021
v1v
added a commit
that referenced
this pull request
Jan 19, 2021
v1v
added a commit
that referenced
this pull request
Jan 19, 2021
v1v
added a commit
that referenced
this pull request
Jan 19, 2021
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
needs_backport
PR is waiting to be backported to other branches.
Team:Automation
Label for the Observability productivity team
v7.11.0
v7.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@jsoriano pointed that the
make check
didn't run when go.mod changes:Why is it important?
Ensure there are no missing licenses in the NOTICE.txt file.