Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23479 to 7.x: Support for linux/arm64 #23522

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #23479 to 7.x branch. Original message:

What does this PR do?

Just adds a correct arch for arm64 so arm64 beats are downloaded.
Tested on AWS arm64 server, dashboards seemed ok.

Why is it important?

support Arm 64 packages

How to test

Ideally you have an arm64 device or libvirt enabled and it's easy.
What i did is that I

  • built binary using DEV=true SNAPSHOT=TRUE PLATFORMS="linux/arm64" mage package command
  • used my AWS subscription to spin-up ARM64 Ubuntu server,
  • scp-ed arm packaged there
  • ssh, untar and clear data/elastic-agent-*/downloads directory
  • install with fleet 8.0.0-SNAPSHOT
  • everything should be ok and dashboards populated

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 15, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23522 opened

    • Start Time: 2021-01-15T09:03:17.803+0000
  • Duration: 17 min 19 sec

  • Commit: af5ad86

Test stats 🧪

Test Results
Failed 0
Passed 1414
Skipped 6
Total 1420

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1414
Skipped 6
Total 1420

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 424b34b into elastic:7.x Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants