Log total non-zero expvars on shutdown #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
LGTM. Worth a CHANGELOG entry |
tsg
force-pushed
the
log_expvars_at_end
branch
from
bf26ac4
to
5d522df
Compare
|
@ruflin Added now, along with docs and test updates. |
tsg
force-pushed
the
log_expvars_at_end
branch
from
5d522df
to
fa90047
Compare
| @@ -751,7 +751,8 @@ output.elasticsearch: | |||
|
|
|||
| # If enabled, filebeat periodically logs its internal metrics that have changed | |||
| # in the last period. For each metric that changed, the delta from the value at | |||
| # the beginning of the period is logged. The default is true. | |||
| # the beginning of the period is logged. Also, the total values for | |||
| # all non-zero internal metrics are logged on shutdown.The default is true. | |||
Replaces the similar functionality from Metricbeat and Winlogbeat, generalizing it to all Beats. Part of elastic#1931.
tsg
force-pushed
the
log_expvars_at_end
branch
from
fa90047
to
808f09e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the similar functionality from Metricbeat and Winlogbeat,
generalizing it to all Beats. Part of #1931.