Cherry-pick #23344 to 7.x: Provide more ways to set AWS credentials in Functionbeat #23386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
[zube]: In Review
backport
Team:Services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
This PR makes credential settings when deploying Lambdas to AWS more flexible. New options are introduced:
1. `access_key_id`, `secret_access_key` and/or `session_token` for tokens
```yaml
functionbeat.provider.aws.access_key_id: '${AWS_ACCESS_KEY_ID:""}'
functionbeat.provider.aws.secret_access_key: '${AWS_SECRET_ACCESS_KEY:""}'
functionbeat.provider.aws.session_token: '${AWS_SESSION_TOKEN:""}'
```
2. `role_arn` for assuming IAM roles
```yaml
functionbeat.provider.aws.role_arn: arn:aws:iam::123456789012:role/test-fnb
```
3. `credential_profile_name` and/or `shared_credential_file` for credential files
```yaml
functionbeat.provider.aws.credential_profile_name: fnb-aws
functionbeat.provider.aws.shared_credential_file: /etc/functionbeat/aws_credentials
```
Credential configuration becomes more flexible and follows the same pattern as in Filebeat and Metricbeat.
Based on elastic#17658
Closes elastic#12464
Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 5e6558b)
kvch
force-pushed
the
backport_23344_7.x
branch
from
2711873 to
1f484d4
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 5574 |
| Skipped | 396 |
| Total | 5970 |
kaiyan-sheng
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23344 to 7.x branch. Original message:
What does this PR do?
This PR makes credential settings when deploying Lambdas to AWS more flexible. New options are introduced:
access_key_id,secret_access_keyand/orsession_tokenfor tokensrole_arnfor assuming IAM rolescredential_profile_nameand/orshared_credential_filefor credential filesWhy is it important?
Credential configuration becomes more flexible and follows the same pattern as in Filebeat and Metricbeat.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Based on #17658
Closes #12464