Changed ilmDefaultPattern to start with 0 insted of 1

[Skoetting]

What does this PR do?

Changed the Default ILM Pattern to start counting at 0 instead of 1 as suggested in #20648

Why is it important?

Copied from issue #20648 "We do try to index from 0 after all :)"

Checklist

• [ X] My code follows the style guidelines of this project
• [ X] I have commented my code, particularly in hard-to-understand areas
• [ X] I have made corresponding changes to the documentation
• [ X] I have made corresponding change to the default configuration files
• [ X] I have added tests that prove my fix is effective or that my feature works
• [ X] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Closes Start ILM counter at 0 #20648

[botelastic]

This pull request doesn't have a Team:<team> label.

[cla-checker-service]

❌ Author of the following commits did not sign a Contributor Agreement:
370abd3, f654d40

Please, read and sign the above mentioned agreement if you want to contribute to this project

[Skoetting]

Hi Team,
I allready signed the agreement awhile ago.
Also had another PR in a Elstic Repo without any Problems. (see elastic/elasticsearch#57520)

I just signed it again.

[elasticmachine]

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Pull request #23295 updated

• Reason: The PR is not allowed to run in the CI yet

• Start Time: 2020-12-28T11:27:36.557+0000

• Duration: 5 min 23 sec

• Commit: f654d40

Steps errors

Expand to view the steps failures

Error signal

• Took 0 min 0 sec . View more details on here
• Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output

Expand to view the last 100 lines of log output

[2020-12-28T11:31:14.375Z]  > git fetch --no-tags --progress --prune -- [email protected]:elastic/beats.git +refs/pull/23295/head:refs/remotes/origin/PR-23295 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-12-28T11:31:15.494Z] Merging remotes/origin/master commit 27d0f08c30b6495cc4880262a2120cef5c21fdfe into PR head commit f654d404f31e96f472fb97db6c77cc621e462e51
[2020-12-28T11:31:15.500Z]  > git config core.sparsecheckout # timeout=10
[2020-12-28T11:31:15.505Z]  > git checkout -f f654d404f31e96f472fb97db6c77cc621e462e51 # timeout=15
[2020-12-28T11:31:16.964Z] Merge succeeded, producing f654d404f31e96f472fb97db6c77cc621e462e51
[2020-12-28T11:31:16.965Z] Checking out Revision f654d404f31e96f472fb97db6c77cc621e462e51 (PR-23295)
[2020-12-28T11:31:16.935Z]  > git remote # timeout=10
[2020-12-28T11:31:16.940Z]  > git config --get remote.origin.url # timeout=10
[2020-12-28T11:31:16.945Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-28T11:31:16.948Z]  > git merge 27d0f08c30b6495cc4880262a2120cef5c21fdfe # timeout=10
[2020-12-28T11:31:16.960Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-12-28T11:31:16.967Z]  > git config core.sparsecheckout # timeout=10
[2020-12-28T11:31:16.971Z]  > git checkout -f f654d404f31e96f472fb97db6c77cc621e462e51 # timeout=15
[2020-12-28T11:31:21.708Z] Commit message: "changelog"
[2020-12-28T11:31:21.708Z] First time build. Skipping changelog.
[2020-12-28T11:31:21.708Z] Cleaning workspace
[2020-12-28T11:31:22.420Z] Timeout set to expire in 3 hr 0 min
[2020-12-28T11:31:22.431Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2020-12-28T11:31:22.548Z] [INFO] Number of builds to be searched 10
[2020-12-28T11:31:22.582Z] [INFO] Let's stop build #1. Aborted from #2
[2020-12-28T11:31:23.118Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2020-12-28T11:31:23.128Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23295/src/github.com/elastic/beats
[2020-12-28T11:31:23.139Z] [INFO] gitCheckout: Checkout SCM PR-23295 with default customisation from the Item.
[2020-12-28T11:31:23.155Z] [INFO] Override default checkout
[2020-12-28T11:31:23.178Z] Sleeping for 10 sec
[2020-12-28T11:31:21.711Z]  > git rev-parse --verify HEAD # timeout=10
[2020-12-28T11:31:21.715Z] Resetting working tree
[2020-12-28T11:31:21.715Z]  > git reset --hard # timeout=10
[2020-12-28T11:31:21.787Z]  > git clean -fdx # timeout=10
[2020-12-28T11:31:33.193Z] The recommended git tool is: git
[2020-12-28T11:31:33.232Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2020-12-28T11:31:33.260Z] Wiping out workspace first.
[2020-12-28T11:31:33.267Z] Cloning the remote Git repository
[2020-12-28T11:31:33.267Z] Using shallow clone with depth 10
[2020-12-28T11:31:33.268Z] Avoid fetching tags
[2020-12-28T11:31:33.289Z] Cloning repository [email protected]:elastic/beats.git
[2020-12-28T11:31:33.308Z]  > git init /var/lib/jenkins/workspace/Beats_beats_PR-23295/src/github.com/elastic/beats # timeout=10
[2020-12-28T11:31:33.313Z] Fetching upstream changes from [email protected]:elastic/beats.git
[2020-12-28T11:31:33.313Z]  > git --version # timeout=10
[2020-12-28T11:31:33.316Z]  > git --version # 'git version 2.17.1'
[2020-12-28T11:31:33.317Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-28T11:31:33.321Z]  > git fetch --no-tags --progress -- [email protected]:elastic/beats.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2020-12-28T11:31:53.478Z] Cleaning workspace
[2020-12-28T11:31:53.490Z] Using shallow fetch with depth 10
[2020-12-28T11:31:53.490Z] Pruning obsolete local branches
[2020-12-28T11:31:53.464Z]  > git config remote.origin.url [email protected]:elastic/beats.git # timeout=10
[2020-12-28T11:31:53.468Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-12-28T11:31:53.474Z]  > git config remote.origin.url [email protected]:elastic/beats.git # timeout=10
[2020-12-28T11:31:53.481Z]  > git rev-parse --verify HEAD # timeout=10
[2020-12-28T11:31:53.484Z] No valid HEAD. Skipping the resetting
[2020-12-28T11:31:53.484Z]  > git clean -fdx # timeout=10
[2020-12-28T11:31:53.492Z] Fetching upstream changes from [email protected]:elastic/beats.git
[2020-12-28T11:31:53.492Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-28T11:31:53.496Z]  > git fetch --no-tags --progress --prune -- [email protected]:elastic/beats.git +refs/pull/23295/head:refs/remotes/origin/PR-23295 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-12-28T11:31:54.919Z] Merging remotes/origin/master commit 27d0f08c30b6495cc4880262a2120cef5c21fdfe into PR head commit f654d404f31e96f472fb97db6c77cc621e462e51
[2020-12-28T11:31:56.347Z] Merge succeeded, producing f654d404f31e96f472fb97db6c77cc621e462e51
[2020-12-28T11:31:56.348Z] Checking out Revision f654d404f31e96f472fb97db6c77cc621e462e51 (PR-23295)
[2020-12-28T11:31:54.921Z]  > git config core.sparsecheckout # timeout=10
[2020-12-28T11:31:54.924Z]  > git checkout -f f654d404f31e96f472fb97db6c77cc621e462e51 # timeout=15
[2020-12-28T11:31:56.321Z]  > git remote # timeout=10
[2020-12-28T11:31:56.325Z]  > git config --get remote.origin.url # timeout=10
[2020-12-28T11:31:56.331Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-28T11:31:56.334Z]  > git merge 27d0f08c30b6495cc4880262a2120cef5c21fdfe # timeout=10
[2020-12-28T11:31:56.343Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-12-28T11:31:56.350Z]  > git config core.sparsecheckout # timeout=10
[2020-12-28T11:31:56.352Z]  > git checkout -f f654d404f31e96f472fb97db6c77cc621e462e51 # timeout=15
[2020-12-28T11:31:56.923Z] Commit message: "changelog"
[2020-12-28T11:31:56.923Z] Cleaning workspace
[2020-12-28T11:31:58.340Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-12-28T11:31:58.914Z] + git fetch https://****:****@github.com/elastic/beats.git +refs/pull/*/head:refs/remotes/origin/pr/*
[2020-12-28T11:31:56.925Z]  > git rev-parse --verify HEAD # timeout=10
[2020-12-28T11:31:56.928Z] Resetting working tree
[2020-12-28T11:31:56.929Z]  > git reset --hard # timeout=10
[2020-12-28T11:31:57.502Z]  > git clean -fdx # timeout=10
[2020-12-28T11:32:55.166Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23295/src/github.com/elastic/beats/.git
[2020-12-28T11:32:55.181Z] Archiving artifacts
[2020-12-28T11:32:55.797Z] + git rev-parse HEAD
[2020-12-28T11:32:56.098Z] + git rev-parse HEAD
[2020-12-28T11:32:56.387Z] + git rev-parse origin/pr/23295
[2020-12-28T11:32:56.416Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-12-28T11:32:56.633Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-12-28T11:32:57.355Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/beats/pulls/23295/reviews return 0 elements
[2020-12-28T11:32:57.376Z] [INFO] githubPrCheckApproved: Title: Changed ilmDefaultPattern to start with 0 insted of 1 - User: Skoetting - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-12-28T11:32:57.574Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2020-12-28T11:32:57.574Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2020-12-28T11:32:57.597Z] [INFO] Let's stop build #2. The PR is not allowed to run in the CI yet
[2020-12-28T11:32:57.607Z] Sleeping for 5 sec
[2020-12-28T11:32:58.971Z] Stage "Lint" skipped due to earlier failure(s)
[2020-12-28T11:32:58.994Z] Stage "Build&Test" skipped due to earlier failure(s)
[2020-12-28T11:32:59.018Z] Stage "Packaging" skipped due to earlier failure(s)
[2020-12-28T11:32:59.054Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23295/src/github.com/elastic/beats
[2020-12-28T11:32:59.240Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-23295
[2020-12-28T11:32:59.305Z] [INFO] getVaultSecret: Getting secrets
[2020-12-28T11:32:59.354Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-12-28T11:32:59.993Z] + chmod 755 generate-build-data.sh
[2020-12-28T11:32:59.994Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23295/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23295/runs/2 ABORTED 323176
[2020-12-28T11:33:00.544Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23295/runs/2/steps/?limit=10000 -o steps-info.json
[2020-12-28T11:33:00.794Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23295/runs/2/tests/?status=FAILED -o tests-errors.json
[2020-12-28T11:33:00.794Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2020-12-28T11:33:02.137Z] Retry 2/3 exited 22, retrying in 2 seconds...