Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23215 to 7.x: [Filebeat] Add pubsub_alternative_host to gcp pubsub input #23244

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Cherry-pick #23215 to 7.x: [Filebeat] Add pubsub_alternative_host to gcp pubsub input #23244

merged 1 commit into from
Dec 22, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 22, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #23215 to 7.x branch. Original message:

What does this PR do?

Adds an option to set a custom pubsub alternative host to pubsub input.

Why is it important?

To be able to start the input using the GCP Pubsub emulator we needed a way to configure it to point to our testing host and bypass credential initialization.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation (we do not want to document that as it is intended for testing)
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 22, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 22, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23244 updated

  • Start Time: 2020-12-22T16:10:05.661+0000

  • Duration: 46 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 2436
Skipped 263
Total 2699

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2436
Skipped 263
Total 2699

andrewkroh
andrewkroh approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is an jenkins failure to look into.

@marc-gr
Copy link
Contributor Author

marc-gr commented Dec 22, 2020

LGTM, but there is an jenkins failure to look into.

it is fixed by #23242 (and #23241) which will need to go in first

@marc-gr
[Filebeat] Add pubsub_alternative_host to gcp pubsub input (elastic#2…
7eabfc8 
…3215)

* Add pubsub_alternative_host to gcp pubsub input

* Apply suggestions

* Add changelog entry

* Add new option comment

* Make error more descriptive and reorder imports

(cherry picked from commit 545598f)
@marc-gr marc-gr merged commit e4e4d98 into elastic:7.x Dec 22, 2020
@marc-gr marc-gr deleted the backport_23215_7.x branch December 22, 2020 17:01
@zube zube bot removed the [zube]: Done label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @andrewkroh