Fix vsphere.datastore.capacity.used.pct value by removing *100

CHANGELOG.next.asciidoc

@@ -467,6 +467,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
 - Add support for azure light metricset app_stats. {pull}20639[20639]
 - Fix remote_write flaky test. {pull}21173[21173]
 - Remove io.time from windows {pull}22237[22237]
+- Change vsphere.datastore.capacity.used.pct value to betweeen 0 and 1. {pull}23148[23148]
 
 *Packetbeat*
 

metricbeat/docs/fields.asciidoc

@@ -46384,7 +46384,7 @@ format: bytes
 Used percent of the datastore
 
 
-type: long
+type: scaled_float
 
 format: percent
 

metricbeat/module/vsphere/datastore/_meta/data.json

@@ -1,27 +1,30 @@
 {
     "@timestamp": "2017-10-12T08:05:34.853Z",
-    "beat": {
-        "hostname": "host.example.com",
-        "name": "host.example.com"
+    "event": {
+        "dataset": "vsphere.datastore",
+        "duration": 115000,
+        "module": "vsphere"
     },
     "metricset": {
-        "host": "http://127.0.0.1:36937/sdk",
-        "module": "vsphere",
         "name": "datastore",
-        "rtt": 115
+        "period": 10000
+    },
+    "service": {
+        "address": "http://127.0.0.1:51027/sdk",
+        "type": "vsphere"
     },
     "vsphere": {
         "datastore": {
             "capacity": {
                 "free": {
-                    "bytes": 50021150720
+                    "bytes": 267958476800
                 },
                 "total": {
-                    "bytes": 63918878720
+                    "bytes": 484736266240
                 },
                 "used": {
-                    "bytes": 13897728000,
-                    "pct": 21
+                    "bytes": 216777789440,
+                    "pct": 0.44720769733509097
                 }
             },
             "fstype": "local",

metricbeat/module/vsphere/datastore/_meta/fields.yml

@@ -28,7 +28,7 @@
         Used bytes of the datastore
       format: bytes
     - name: capacity.used.pct
-      type: long
+      type: scaled_float
       description: >
         Used percent of the datastore
       format: percent

metricbeat/module/vsphere/datastore/datastore.go

@@ -111,9 +111,9 @@ func (m *MetricSet) Fetch(ctx context.Context, reporter mb.ReporterV2) error {
 	}
 
 	for _, ds := range dst {
-		var usedSpacePercent int64
+		var usedSpacePercent float64
 		if ds.Summary.Capacity > 0 {
-			usedSpacePercent = 100 * (ds.Summary.Capacity - ds.Summary.FreeSpace) / ds.Summary.Capacity
+			usedSpacePercent = float64(ds.Summary.Capacity-ds.Summary.FreeSpace) / float64(ds.Summary.Capacity)
 		}
 		usedSpaceBytes := ds.Summary.Capacity - ds.Summary.FreeSpace
 

metricbeat/module/vsphere/datastore/datastore_test.go

@@ -58,7 +58,9 @@ func TestFetchEventContents(t *testing.T) {
 		if err != nil {
 			t.Error(err)
 		} else {
-			isNonNegativeInt64(t, field, value)
+			if field != "capacity.used.pct" {
+				isNonNegativeInt64(t, field, value)
+			}
 		}
 	}
 }