Cherry-pick #21861 to 7.x: chore: delegate variant pushes to the right method #23124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: delegate pushes to variants * chore: group conditions for x-pack * chore: simplify with endsWith Co-authored-by: Victor Martinez <[email protected]> Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit e2f41f9c367c8d92b6ca5749f2cb7e4e08314593)
jsoriano
added
[zube]: In Review
backport
Team:Automation
botelastic
bot
added
needs_team
|
Trying to fix some issues with tag and push in 7.x branch. Like this one: https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fpackaging/detail/PR-23110/3/pipeline |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. |
|
/package |
kaiyan-sheng
approved these changes
Dec 14, 2020
|
/packaging |
* fix: push ubi8 images too * chore: enhance retries Co-authored-by: Victor Martinez <[email protected]> * chore: use variables in log * chore: add "-oss" images Co-authored-by: Victor Martinez <[email protected]>
|
Cherry-picking #21621 too as it might be related. |
|
/packaging |
|
/package |
1 similar comment
|
/package |
|
Closing this in favour of #23142, that includes some changes that were backported to 7.10, but not to 7.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21861 and #21621 to 7.x branch. Original message:
What does this PR do?
It groups the conditions for pushing the docker image of each beat, because the logic for the variants is responsible of pushing or logging a warning if the image exists.
Why is it important?
It won't push some of the images twice, also simplifying the IF/ELSE logic.
Apart from that, there are wrong image names after the addition of variants, like
filebeat-oss-oss.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Related issues