Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Fix DEB/RPM installation #23038

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Dec 9, 2020

What does this PR do?

Fixes an issue where the DEB/RPM was writing the wrong file to /usr/bin/elastic-agent.

Why is it important?

So DEB/RPM installations of Elastic Agent work.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse self-assigned this Dec 9, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@blakerouse blakerouse marked this pull request as ready for review December 9, 2020 18:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23038 updated

  • Start Time: 2020-12-09T18:20:53.079+0000

  • Duration: 62 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 17378
Skipped 1373
Total 18751

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 14 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17378
Skipped 1373
Total 18751

@blakerouse
Copy link
Contributor Author

/packaging

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blakerouse blakerouse merged commit 4807b3f into elastic:master Dec 14, 2020
@blakerouse blakerouse deleted the fix-22744 branch December 14, 2020 18:58
blakerouse added a commit to blakerouse/beats that referenced this pull request Dec 14, 2020
* Update filename to not overwrite other file when package is built.

* Add changelog.

(cherry picked from commit 4807b3f)
blakerouse added a commit to blakerouse/beats that referenced this pull request Dec 14, 2020
* Update filename to not overwrite other file when package is built.

* Add changelog.

(cherry picked from commit 4807b3f)
blakerouse added a commit that referenced this pull request Dec 15, 2020
* Update filename to not overwrite other file when package is built.

* Add changelog.

(cherry picked from commit 4807b3f)
blakerouse added a commit that referenced this pull request Dec 15, 2020
* Update filename to not overwrite other file when package is built.

* Add changelog.

(cherry picked from commit 4807b3f)
@ghost
Copy link

ghost commented Jan 12, 2021

Hi @EricDavisX

We have performed regression testing for Linux deb/rpm on 7.10.2 BC1 Kibana cloud build. Build details is as follows:

Platform: Staging
Version: 7.10.2
Commit: a0b7936
Build number: 36136
Artifact: https://staging.elastic.co/7.10.2-e6b2b8c2/summary-7.10.2.html

We have execute test cases under test plan execution :

Please let us know if anything else is required to be covered.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants