-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clusterName, taskName, cloud.region and dashboard to aws fargate #22941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Dec 5, 2020
kaiyan-sheng
added
needs_backport
PR is waiting to be backported to other branches.
Team:Platforms
Label for the Integrations - Platforms team
labels
Dec 5, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Dec 5, 2020
Collaborator
kaiyan-sheng
changed the title
Add clusterName, taskName and cloud.region to aws fargate
Add clusterName, taskName, cloud.region and dashboard to aws fargate
Dec 8, 2020
6 tasks
kaiyan-sheng
added
review
and removed
in progress
Pull request is currently in progress.
labels
Dec 8, 2020
ChrsMark
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks!
6 tasks
kaiyan-sheng
added
v7.11.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Dec 9, 2020
6 tasks
kaiyan-sheng
added a commit
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to add extra fields for cluster name, task name, cloud region and an identifier for AWS fargate.
Why is it important?
When creating AWS Fargate tasks with the same container/container name, Kibana dashboard get confused and only displaying part of the data. I would like to introduce an
awsfargate.identifier
=containerName
+ "/" +containerID
to make sure we can distinguish containers from different task or cluster.Checklist
I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Screenshot