-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for CloudFoundry application metadata persistent cache #22669
Add documentation for CloudFoundry application metadata persistent cache #22669
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a suggestion but may be something obvious 🙂 so feel free to ignore it.
For efficient annotation, application metadata retrieved by the Cloud Foundry | ||
client is stored in a persistent cache on the filesystem under the `path.data` | ||
directory. For control over this cache, use the `cache_duration` and | ||
`cache_retry_delay` settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should mention that this is intended to persist metadata between restarts, and for that the data directory should be preserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ will add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR do?
This PR documents the CloudFoundry application metadata persistent cache feature implemented in #20775.
Why is it important?
So users of the
add_cloudfoundry_metadata
processors know about the persistent cache.Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues