Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cassandra and icmp comments in packetbeat.yml #22584

Merged
merged 4 commits into from
Jan 24, 2021
Merged

Fix cassandra and icmp comments in packetbeat.yml #22584

merged 4 commits into from
Jan 24, 2021

Conversation

yzdann
Copy link
Contributor

@yzdann yzdann commented Nov 14, 2020

  • Enhancement
  • Docs

What does this PR do?

Fix and Uniform comments in packetbeat.yml

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 14, 2020
@cla-checker-service
Copy link

cla-checker-service bot commented Nov 14, 2020

💚 CLA has been signed

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 14, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22584 updated

    • Start Time: 2021-01-13T21:05:59.973+0000
  • Duration: 26 min 13 sec

  • Commit: 4f02183

Test stats 🧪

Test Results
Failed 0
Passed 1081
Skipped 10
Total 1091

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1081
Skipped 10
Total 1091

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 15, 2020
@botelastic
Copy link

botelastic bot commented Dec 16, 2020

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 16, 2020
@yzdann
Copy link
Contributor Author

yzdann commented Dec 16, 2020

👍

@botelastic botelastic bot removed the Stalled label Dec 16, 2020
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the templates used to generate the config files with your changes.

@andrewkroh andrewkroh merged commit 6cad281 into elastic:master Jan 24, 2021
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request Jan 24, 2021
* Uniform cassandra comment in packetbeat.yml

* Fix icmp comment in packetbeat.yml

* Uniform SIP comment in packetbeat.yml

* Update the config templates

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 6cad281)
andrewkroh added a commit that referenced this pull request Jan 25, 2021
* Uniform cassandra comment in packetbeat.yml

* Fix icmp comment in packetbeat.yml

* Uniform SIP comment in packetbeat.yml

* Update the config templates

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 6cad281)

Co-authored-by: Yazdan <[email protected]>
@andrewkroh andrewkroh mentioned this pull request Jan 25, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants