-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cassandra and icmp comments in packetbeat.yml #22584
Conversation
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Hi! We're labeling this issue as |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the templates used to generate the config files with your changes.
* Uniform cassandra comment in packetbeat.yml * Fix icmp comment in packetbeat.yml * Uniform SIP comment in packetbeat.yml * Update the config templates Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 6cad281)
* Uniform cassandra comment in packetbeat.yml * Fix icmp comment in packetbeat.yml * Uniform SIP comment in packetbeat.yml * Update the config templates Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 6cad281) Co-authored-by: Yazdan <[email protected]>
What does this PR do?
Fix and Uniform comments in packetbeat.yml
Why is it important?
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs