Cherry-pick #20330 to 7.x: [Heartbeat] Use service.name not service_name in configs #22574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the nesting this way lets us handle future fields like service.environment more cleanly if/when they become available. See https://github.com/elastic/ecs/blob/master/rfcs/text/0002-rfc-environment.md for the proposal to add service.environment This is a follow-up to elastic#19932 which has not yet been released, so this is not a breaking change. (cherry picked from commit 425271b)
andrewvc
added
[zube]: In Review
backport
Team:obs-ds-hosted-services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
removed
the
needs_team
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Thanks @andrewvc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20330 to 7.x branch. Original message:
Using the nesting this way lets us handle future fields like
service.environmentmore cleanly if/when they become available.See https://github.com/elastic/ecs/blob/master/rfcs/text/0002-rfc-environment.md
for the proposal to add service.environment
This is a follow-up to #19932 which has not yet been released, so this is not a breaking change.
CC @cyrille-leclerc who pointed out that this would be better.