Start of PostgreSQL module #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
in progress
| - module: postgresql | ||
| metricsets: ["activity"] | ||
| enabled: true | ||
| period: 1s |
There was a problem hiding this comment.
should we set the default here also to 10s like the other metricsets?
There was a problem hiding this comment.
Yes, it's one of the the TODOs above :)
|
LGTM |
| } | ||
|
|
||
| // Fetch methods implements the data gathering and data conversion to the right format | ||
| // It returns the event which is then forward to the output. In case of an error, a |
There was a problem hiding this comment.
You could also remove the generator comments here and above for init and New.
tsg
force-pushed
the
metricbeat_postgres
branch
2 times, most recently
from
da73af5
to
6abea48
Compare
A start for the Metricbeat Postgresql module. The core functionality for connecting and an `activity` metricset is done.
tsg
force-pushed
the
metricbeat_postgres
branch
from
6abea48
to
770f303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A start for the Metricbeat Postgresql module.
The activity metricset (with data about the currently running processes) is done.