Cherry-pick #20450 to 7.x: Check if Filebeat log harvester tries to open named pipe #22422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What does this PR do? This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened. ## Why is it important? Previously if someone wanted to open a named pipe without a writer, Filebeat hangs. ## Related issues Closes elastic#18682 (cherry picked from commit a89d81f)
kvch
added
[zube]: In Review
backport
Team:Services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
michalpristas
approved these changes
Nov 4, 2020
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20450 to 7.x branch. Original message:
What does this PR do?
This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened.
Why is it important?
Previously if someone wanted to open a named pipe without a writer, Filebeat hangs.
Checklist
- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #18682